Skip to content

Commit b437119

Browse files
committed
Remove last use of v4 jwtauth
1 parent d5a75bb commit b437119

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

backend/go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ require (
1313
github.com/glebarez/sqlite v1.8.0
1414
github.com/go-chi/chi/v5 v5.0.8
1515
github.com/go-chi/cors v1.2.1
16-
github.com/go-chi/jwtauth v4.0.4+incompatible
1716
github.com/go-chi/jwtauth/v5 v5.1.0
1817
github.com/jc21/go-sse v0.0.0-20230307071053-2e6b1dbcb7ec
1918
github.com/jc21/jsref v0.0.0-20210608024405-a97debfc4760
@@ -36,7 +35,6 @@ require (
3635
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.1.0 // indirect
3736
github.com/dustin/go-humanize v1.0.1 // indirect
3837
github.com/glebarez/go-sqlite v1.21.1 // indirect
39-
github.com/go-chi/chi v4.1.2+incompatible // indirect
4038
github.com/go-sql-driver/mysql v1.7.1 // indirect
4139
github.com/goccy/go-json v0.9.11 // indirect
4240
github.com/google/uuid v1.3.0 // indirect

backend/go.sum

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,10 @@ github.com/glebarez/go-sqlite v1.21.1 h1:7MZyUPh2XTrHS7xNEHQbrhfMZuPSzhkm2A1qgg0
2626
github.com/glebarez/go-sqlite v1.21.1/go.mod h1:ISs8MF6yk5cL4n/43rSOmVMGJJjHYr7L2MbZZ5Q4E2E=
2727
github.com/glebarez/sqlite v1.8.0 h1:02X12E2I/4C1n+v90yTqrjRa8yuo7c3KeHI3FRznCvc=
2828
github.com/glebarez/sqlite v1.8.0/go.mod h1:bpET16h1za2KOOMb8+jCp6UBP/iahDpfPQqSaYLTLx8=
29-
github.com/go-chi/chi v4.1.2+incompatible h1:fGFk2Gmi/YKXk0OmGfBh0WgmN3XB8lVnEyNz34tQRec=
30-
github.com/go-chi/chi v4.1.2+incompatible/go.mod h1:eB3wogJHnLi3x/kFX2A+IbTBlXxmMeXJVKy9tTv1XzQ=
3129
github.com/go-chi/chi/v5 v5.0.8 h1:lD+NLqFcAi1ovnVZpsnObHGW4xb4J8lNmoYVfECH1Y0=
3230
github.com/go-chi/chi/v5 v5.0.8/go.mod h1:DslCQbL2OYiznFReuXYUmQ2hGd1aDpCnlMNITLSKoi8=
3331
github.com/go-chi/cors v1.2.1 h1:xEC8UT3Rlp2QuWNEr4Fs/c2EAGVKBwy/1vHx3bppil4=
3432
github.com/go-chi/cors v1.2.1/go.mod h1:sSbTewc+6wYHBBCW7ytsFSn836hqM7JxpglAy2Vzc58=
35-
github.com/go-chi/jwtauth v4.0.4+incompatible h1:LGIxg6YfvSBzxU2BljXbrzVc1fMlgqSKBQgKOGAVtPY=
36-
github.com/go-chi/jwtauth v4.0.4+incompatible/go.mod h1:Q5EIArY/QnD6BdS+IyDw7B2m6iNbnPxtfd6/BcmtWbs=
3733
github.com/go-chi/jwtauth/v5 v5.1.0 h1:wJyf2YZ/ohPvNJBwPOzZaQbyzwgMZZceE1m8FOzXLeA=
3834
github.com/go-chi/jwtauth/v5 v5.1.0/go.mod h1:MA93hc1au3tAQwCKry+fI4LqJ5MIVN4XSsglOo+lSc8=
3935
github.com/go-errors/errors v1.4.2 h1:J6MZopCL4uSllY1OfXM374weqZFFItUbrImctkmUxIA=

backend/internal/api/handler/schema.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@ func getSchema() []byte {
4848
return nil
4949
}
5050

51-
provider := provider.NewIoFS(apiDocsSub, "")
51+
prov := provider.NewIoFS(apiDocsSub, "")
5252
resolver := jsref.New()
53-
err := resolver.AddProvider(provider)
53+
err := resolver.AddProvider(prov)
5454
if err != nil {
5555
logger.Error("SchemaProviderError", err)
5656
}

backend/internal/api/middleware/sse_auth.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
h "npm/internal/api/http"
77
"npm/internal/entity/user"
88

9-
"github.com/go-chi/jwtauth"
9+
"github.com/go-chi/jwtauth/v5"
1010
)
1111

1212
// SSEAuth will validate that the jwt token provided to get this far is a SSE token
@@ -33,7 +33,13 @@ func SSEAuth(next http.Handler) http.Handler {
3333

3434
userID := uint(claims["uid"].(float64))
3535
_, enabled := user.IsEnabled(userID)
36-
if token == nil || !token.Valid || !enabled || !claims.VerifyIssuer("sse", true) {
36+
if token == nil || !enabled {
37+
h.ResultErrorJSON(w, r, http.StatusUnauthorized, "Unauthorised", nil)
38+
return
39+
}
40+
41+
iss, _ := token.Get("iss")
42+
if iss != "sse" {
3743
h.ResultErrorJSON(w, r, http.StatusUnauthorized, "Unauthorised", nil)
3844
return
3945
}

0 commit comments

Comments
 (0)