-
Notifications
You must be signed in to change notification settings - Fork 3.2k
CloudFlare DNS Challenge #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds LETSENCRYPT CLOUDFLARE DNS CHALLANGE
.env file to configure Cloudflare DNS challange
Add your ___domain to have a wildcard cert generated
Added letsencrypt-dns Service
Docker Image for build 1 is available on DockerHub as |
sorry to be a bit of a dunce here... but after adding the LE docker and the conf and Env configured... how do i utilize this? |
Any status on this PR? This would be a great addition IMO. |
@jodfie makes a good point, I'd be happier to merge this if there was a new readme file in the |
Also, please change this PR to the |
Hey @OhHeyAlan, can you make these changes? Would love to see this committed. |
bumping this again to ask @OhHeyAlan if he can correct this so it can be implemented and also how to set it up?... |
@jc21 is there any chance this will be merged or re-implemented soon?. DNS-Challenge would be awesome, as a lot of us don't publish our Proxy as it is part of our home/internal network. |
I've been checking this PR. It only adds the necessary code to launch another container to do the DNS-Challenge and to download the certificates, but it doesn't add any value to NPM itself using the app as the certificate manager using DNS Challenge. We already can download the certificates via multiple ways using externals tools (the container used in this PR, acme.sh, certbot installed locally...), which is what this PR is doing. I've been also checking the NPM repo and if I could follow the code properly (I'm not a Node/Javascript person) I've not seen an automatic way to import .pem/.crt&.key from a directory. Maybe, if there would be a way to do it, this PR (or other tools) could work as we could share/use volumes to share the data between the certificates downloader and NPM. Is there a way to import certificates from a directory?. |
No there isn't a way to do this - but a bash script that curl's the NPM API would be enough to add or update certs. But yes I agree, adding another container to the stack doesn't really solve the root cause: the interface and flow doesn't support dns challenges well at all. |
Not sure how to route the certs to the backend of Nginx-Proxy-Manager but I can confirm that running this stack will allow LetsEncrypt/CertBot to do a DNS challenge via CloudFlare for wildcard certs.