Skip to content

File system permission hardening #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mcpattrsn
Copy link

@mcpattrsn mcpattrsn commented Jul 4, 2025

All private key and certificate files (including custom certs and temp files) are now written with 0600 permissions. Directory creation for custom certs uses 0700 permissions.

Its redundant, but ensures it is consistent for all sensitive files.

The catch block is intentionally left empty.

mcpattrsn added 2 commits July 4, 2025 02:24
Always write private keys with restrictive permissions.
@nginxproxymanagerci
Copy link

CI Error:

/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
certbot-node: Pulling from nginxproxymanager/nginx-full
Digest: sha256:3cdbaf1f3e0206689c91098a9147a4ccf2a1a563ab42dbf662a068b186e9832d
Status: Image is up to date for nginxproxymanager/nginx-full:certbot-node
docker.io/nginxproxymanager/nginx-full:certbot-node
�[1;34m❯ �[1;36mTesting backend ...�[0m
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @apidevtools/[email protected]" has unmet peer dependency "openapi-types@>=7".
[4/4] Building fresh packages...
Done in 17.64s.
yarn run v1.22.22
$ /app/node_modules/.bin/eslint .

/app/internal/certificate.js
  552:60  error  Empty block statement  no-empty
  565:60  error  Empty block statement  no-empty
  693:54  error  Empty block statement  no-empty
  728:54  error  Empty block statement  no-empty

✖ 4 problems (4 errors, 0 warnings)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@mcpattrsn mcpattrsn closed this Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant