Skip to content

#65 custom config of ___location / on proxy host pane #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kolbii
Copy link
Contributor

@kolbii kolbii commented Feb 19, 2019

Fixes #65
Adds a new field to Proxy host and puts the generator that code into the root ___location block's body.
screenshot

@jc21
Copy link
Member

jc21 commented Feb 20, 2019

Docker Image for build 4 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-75

@kolbii kolbii closed this Feb 20, 2019
@kolbii kolbii reopened this Feb 20, 2019
@kolbii
Copy link
Contributor Author

kolbii commented Feb 20, 2019

Is this tagjc21/nginx-proxy-manager:github-pr-75 available on DockerHub? Trying to get this image down but it looks like still unpublished

@jc21
Copy link
Member

jc21 commented Feb 20, 2019

Docker Image for build 5 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-75

@jc21
Copy link
Member

jc21 commented Feb 21, 2019

Hmm yeah it said it uploaded it but I can't see it either.

@jc21
Copy link
Member

jc21 commented Feb 21, 2019

Docker Image for build 6 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-75

@jc21
Copy link
Member

jc21 commented Feb 21, 2019

Thanks for contributing to fix this problem. I've been thinking about it and the problem has a simpler solution. The template render of the host nginx config file just needs to ignore the default ___location when one is present in the advanced config. I've made a quick prototype and it works well.

I'd like to keep the configuration simple, and by that I mean not confusing for those not educated in nginx internals. By adding a special configuration on top of the advanced configuration page seems a bit much.

I'll push another PR with my idea should you want to compare and comment.

@kolbii
Copy link
Contributor Author

kolbii commented Feb 21, 2019

You're right. It's simpler like having another input for overriding any params. I'm closing this PR.
However, what do you think about the custom locations section? I think it'd be easier to manage 2+ simple proxied ___location blocks like writing advanced config. Please take a look at the other one #74 by me.

@kolbii kolbii closed this Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants