Skip to content

Fix content of Path Item Object link #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

char0n
Copy link
Contributor

@char0n char0n commented Jun 28, 2021

This change allows to detect this occurence of Path Item Object
with native browser search capability.

Signed-off-by: Vladimir Gorej [email protected]

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this PR looks great from a consistency point of view. Could you please re-target it to versions/3.1.1.md on the v3.1.1-dev branch?

@char0n char0n changed the base branch from main to v3.1.1-dev July 5, 2021 11:34
@char0n
Copy link
Contributor Author

char0n commented Jul 5, 2021

@MikeRalphson branch updated.

@webron
Copy link
Member

webron commented Jul 5, 2021

Might need to re-create the PR and submit it. Since it was originally done on the main branch, the PR now pulls quite a few changes from main to v3.1.1-dev which hide the true change in the PR. It's best if we keep sync PRs separately.

sami-akkawi and others added 22 commits July 5, 2021 19:02
* servers is an array of server

* fix only yaml file

* add servers test

* update schema.json from shema.yaml
The election cycle for 2021 is complete and the existing TSC-elected members have agreed to serve another term. No additional nominations were received.
…s of the spec (OAI#2574)

* workflows: update used actions

* .

* bikeshed rendering (WIP)

* bikeshed; split into v2, v3 directories

* bikeshed; fixes to TOC,code blocks and indent levels

* bikeshed; work from unmodified .md files

* bikeshed; .gitignore

* bikeshed; separate header for v3.0.1 for now

* respec; as an alternative to bikeshed

* Rename bikeshed to md2html

* md2html; current setup

* md2html; wip

* md2html; fix 1 toc bug

* md2html; fix another toc bug

* md2html; fix 1 respec toc bug

* md2html; fix another bikeshed toc bug

* respec; former editor support - needs ReSpec 20.x

* Latest respec tweaks

* pre block css background, RFC ref fixes

* Github gist syntax highlighting css

* md2html: move to scripts dir

* md2html: resolve relative links for examples

* md2html: use respec js from spec.openapis.org site

* md2html: find gist.css regardless of run dir

* md2html: don't mix https and http content (toc)

* md2html; include google analytics

* md2html; build putative versions 4,5 etc

* md2html; tidying up

* md2html; specify lang="en" in html

* build: update deps

* fix: style examples bugs, refs OAI#2488

* fix: update highlightjs call in md2html

* feat: add github action

Signed-off-by: Mike Ralphson <[email protected]>

* build: create a `latest.html` ReSpec version

Signed-off-by: Mike Ralphson <[email protected]>
…re appropriate (OAI#2586)

* Fix typo in v3.1 schema tests

* Remove v3.1 schema test for server variable

JSON Schema can't express this constraint

* v3.1 Schema fix. $ref should be a uri-reference
Does this work? Just pointing out that there is a Subscribe to Calendar button. DIY.
* fix: v2.0 maintainers and version/date

Signed-off-by: Mike Ralphson <[email protected]>

* Add some largely non-visible SEO improvements to the rendered spec

Signed-off-by: Mike Ralphson <[email protected]>
* nuke proposal prefixes

* Add YYYY-MM-DD prefixes to proposal documents

Signed-off-by: Mike Ralphson <[email protected]>
* fix: md2html/build.sh specify bash in shebang

Signed-off-by: Mike Ralphson <[email protected]>

* fix: changes for abstract title in md2html.js

Signed-off-by: Mike Ralphson <[email protected]>
…mas) (OAI#2614)

* Add test cases for valid and invalid top-level schemaObject types

Signed-off-by: Mike Ralphson <[email protected]>

* Update workflow actions to node 14

Signed-off-by: Mike Ralphson <[email protected]>
Makes the workflow trigger match the comment, thus giving people more time to add agenda items
This change allows to detect this occurence of Path Item Object
with native browser search capability.

Signed-off-by: Vladimir Gorej <[email protected]>
@char0n char0n force-pushed the char0n/path-item-object-typo-fix branch from 1fc78bf to 698c816 Compare July 5, 2021 17:02
@char0n
Copy link
Contributor Author

char0n commented Jul 5, 2021

Closing in favor of #2643

@char0n char0n closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants