Skip to content

Commit 07a1a87

Browse files
committed
Those could *not* be transformed to "is (not) None"
1 parent f650343 commit 07a1a87

File tree

1 file changed

+26
-25
lines changed

1 file changed

+26
-25
lines changed

src/main.py

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,9 @@ async def get_current_job(
192192
stmt = (
193193
select(Job)
194194
.where(
195-
((Job.delayed_until <= curtime) | (Job.delayed_until is None))
196-
& (Job.completed is None)
197-
& (Job.failed is None)
195+
((Job.delayed_until <= curtime) | (Job.delayed_until == None))
196+
& (Job.completed == None)
197+
& (Job.failed == None)
198198
)
199199
.order_by(Job.priority.desc(), Job.retry.desc(), Job.id)
200200
.limit(1)
@@ -323,8 +323,8 @@ async def repeat_url_worker():
323323
.join(Job)
324324
.where(
325325
URL.url.in_([job.url.url for job in jobs])
326-
& (Job.completed is None)
327-
& (Job.failed is None)
326+
& (Job.completed == None)
327+
& (Job.failed == None)
328328
)
329329
)
330330
result = await session.scalars(stmt2)
@@ -359,16 +359,17 @@ async def lifespan(_: FastAPI):
359359
global engine, async_session
360360
if engine is None:
361361
engine = sqlalchemy.ext.asyncio.create_async_engine(
362-
environ.get("DATABASE_URL", "sqlite:///db.sqlite")
362+
environ.get("DATABASE_URL", "sqlite:///db.sqlite"),
363+
echo=True,
363364
)
364365
async_session = sqlalchemy.ext.asyncio.async_sessionmaker(
365366
engine, expire_on_commit=False
366367
)
367368
async with engine.begin() as conn:
368369
await conn.run_sync(Base.metadata.create_all)
369-
workers.append(
370-
asyncio.create_task(exception_logger(url_worker(), name="url_worker"))
371-
)
370+
# workers.append(
371+
# asyncio.create_task(exception_logger(url_worker(), name="url_worker"))
372+
# )
372373
workers.append(
373374
asyncio.create_task(
374375
exception_logger(repeat_url_worker(), name="repeat_url_worker")
@@ -453,7 +454,7 @@ async def stats() -> Stats:
453454
(
454455
await session.execute(
455456
select(Job.retry, sqlalchemy.func.count(Job.id))
456-
.where((Job.completed is None) & (Job.failed is None))
457+
.where((Job.completed == None) & (Job.failed == None))
457458
.group_by(Job.retry)
458459
)
459460
).all()
@@ -462,21 +463,21 @@ async def stats() -> Stats:
462463
(
463464
await session.execute(
464465
select(Job.retry, sqlalchemy.func.count(Job.id))
465-
.where(Job.completed is not None)
466+
.where(Job.completed != None)
466467
.group_by(Job.retry)
467468
)
468469
).all()
469470
)
470471
failed = (
471472
await session.scalar(
472-
select(sqlalchemy.func.count(Job.id)).where(Job.failed is not None)
473+
select(sqlalchemy.func.count(Job.id)).where(Job.failed != None)
473474
)
474475
) or 0
475476
batches = (await session.scalar(select(sqlalchemy.func.count(Batch.id)))) or 0
476477
super_recently_archived_urls = (
477478
await session.scalar(
478479
select(sqlalchemy.func.count(URL.id))
479-
.where(URL.last_seen is not None)
480+
.where(URL.last_seen != None)
480481
.where(
481482
URL.last_seen
482483
> datetime.datetime.now(tz=datetime.timezone.utc)
@@ -488,7 +489,7 @@ async def stats() -> Stats:
488489
(
489490
await session.scalar(
490491
select(sqlalchemy.func.count(URL.id))
491-
.where(URL.last_seen is not None)
492+
.where(URL.last_seen != None)
492493
.where(
493494
URL.last_seen
494495
> datetime.datetime.now(tz=datetime.timezone.utc)
@@ -501,7 +502,7 @@ async def stats() -> Stats:
501502
not_recently_archived_urls = (
502503
await session.scalar(
503504
select(sqlalchemy.func.count(URL.id))
504-
.where(URL.last_seen is not None)
505+
.where(URL.last_seen != None)
505506
.where(
506507
URL.last_seen
507508
< datetime.datetime.now(tz=datetime.timezone.utc)
@@ -511,20 +512,20 @@ async def stats() -> Stats:
511512
) or 0
512513
not_archived_urls = (
513514
await session.scalar(
514-
select(sqlalchemy.func.count(URL.id)).where(URL.last_seen is None)
515+
select(sqlalchemy.func.count(URL.id)).where(URL.last_seen == None)
515516
)
516517
) or 0
517518
active_repeat_urls = (
518519
await session.scalar(
519520
select(sqlalchemy.func.count(RepeatURL.id)).where(
520-
RepeatURL.active_since is not None
521+
RepeatURL.active_since != None
521522
)
522523
)
523524
) or 0
524525
inactive_repeat_urls = (
525526
await session.scalar(
526527
select(sqlalchemy.func.count(RepeatURL.id)).where(
527-
RepeatURL.active_since is None
528+
RepeatURL.active_since == None
528529
)
529530
)
530531
) or 0
@@ -676,7 +677,7 @@ def from_job(cls, job: Job, batch_ids: list[int] | None = None):
676677
retry=job.retry,
677678
failed=job.failed,
678679
batches=batch_ids
679-
if batch_ids is not None
680+
if batch_ids != None
680681
else [batch.id for batch in job.batches],
681682
)
682683

@@ -867,16 +868,16 @@ def apply_job_filtering(
867868
# If all 4 are given, we can take a shortcut and not apply anything
868869
if query_params["not_started"]:
869870
in_statement = in_statement.where(
870-
(Job.completed is None)
871-
& (Job.failed is None)
872-
& (Job.delayed_until is None)
871+
(Job.completed == None)
872+
& (Job.failed == None)
873+
& (Job.delayed_until == None)
873874
)
874875
if query_params["completed"]:
875-
in_statement = in_statement.where(Job.completed is not None)
876+
in_statement = in_statement.where(Job.completed != None)
876877
if query_params["delayed"]:
877-
in_statement = in_statement.where(Job.delayed_until is not None)
878+
in_statement = in_statement.where(Job.delayed_until != None)
878879
if query_params["failed"]:
879-
in_statement = in_statement.where(Job.failed is not None)
880+
in_statement = in_statement.where(Job.failed != None)
880881
retry_param_count = [
881882
query_params["retries_less_than"],
882883
query_params["retries_greater_than"],

0 commit comments

Comments
 (0)