Skip to content

Conversation

TechnologistTim
Copy link
Contributor

No description provided.

Copy link
Contributor

@SapphicFire SapphicFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, incorporated some feedback for future consideration

Comment on lines +23 to +24
firstName = userGr.first_name;
email = userGr.email;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future, look to use getters such as getValue('field') instead of getting the GlideElement each time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tip.

@SapphicFire SapphicFire merged commit c07ffe7 into ServiceNowDevProgram:main Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants