Skip to content

Commit 611f408

Browse files
committed
Switch to using the commons toolforge instance fully
So far we used both the urbanecmbot instances and also the commons-android-app toolforge instance for the functioning of the app. The reality is that the commons-android-app instance itself had the ability to return all the data necessary for the app. Use the same to get all the data necessary for the app. Fixes commons-app#5462
1 parent 9e97012 commit 611f408

File tree

2 files changed

+3
-18
lines changed

2 files changed

+3
-18
lines changed

app/src/main/java/fr/free/nrw/commons/di/NetworkingModule.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,7 @@
4848
@SuppressWarnings({"WeakerAccess", "unused"})
4949
public class NetworkingModule {
5050
private static final String WIKIDATA_SPARQL_QUERY_URL = "https://query.wikidata.org/sparql";
51-
private static final String TOOLS_FORGE_URL = "https://tools.wmflabs.org/urbanecmbot/commonsmisc";
52-
53-
private static final String TEST_TOOLS_FORGE_URL = "https://tools.wmflabs.org/commons-android-app/tool-commons-android-app";
51+
private static final String TOOLS_FORGE_URL = "https://tools.wmflabs.org/commons-android-app/tool-commons-android-app";
5452

5553
public static final long OK_HTTP_CACHE_SIZE = 10 * 1024 * 1024;
5654

@@ -91,13 +89,11 @@ public HttpLoggingInterceptor provideHttpLoggingInterceptor() {
9189
public OkHttpJsonApiClient provideOkHttpJsonApiClient(OkHttpClient okHttpClient,
9290
DepictsClient depictsClient,
9391
@Named("tools_forge") HttpUrl toolsForgeUrl,
94-
@Named("test_tools_forge") HttpUrl testToolsForgeUrl,
9592
@Named("default_preferences") JsonKvStore defaultKvStore,
9693
Gson gson) {
9794
return new OkHttpJsonApiClient(okHttpClient,
9895
depictsClient,
9996
toolsForgeUrl,
100-
testToolsForgeUrl,
10197
WIKIDATA_SPARQL_QUERY_URL,
10298
BuildConfig.WIKIMEDIA_CAMPAIGNS_URL,
10399
gson);
@@ -133,14 +129,6 @@ public HttpUrl provideToolsForgeUrl() {
133129
return HttpUrl.parse(TOOLS_FORGE_URL);
134130
}
135131

136-
@Provides
137-
@Named("test_tools_forge")
138-
@NonNull
139-
@SuppressWarnings("ConstantConditions")
140-
public HttpUrl provideTestToolsForgeUrl() {
141-
return HttpUrl.parse(TEST_TOOLS_FORGE_URL);
142-
}
143-
144132
@Provides
145133
@Singleton
146134
@Named(NAMED_COMMONS_WIKI_SITE)

app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public class OkHttpJsonApiClient {
4747
private final OkHttpClient okHttpClient;
4848
private final DepictsClient depictsClient;
4949
private final HttpUrl wikiMediaToolforgeUrl;
50-
private final HttpUrl wikiMediaTestToolforgeUrl;
5150
private final String sparqlQueryUrl;
5251
private final String campaignsUrl;
5352
private final Gson gson;
@@ -57,14 +56,12 @@ public class OkHttpJsonApiClient {
5756
public OkHttpJsonApiClient(OkHttpClient okHttpClient,
5857
DepictsClient depictsClient,
5958
HttpUrl wikiMediaToolforgeUrl,
60-
HttpUrl wikiMediaTestToolforgeUrl,
6159
String sparqlQueryUrl,
6260
String campaignsUrl,
6361
Gson gson) {
6462
this.okHttpClient = okHttpClient;
6563
this.depictsClient = depictsClient;
6664
this.wikiMediaToolforgeUrl = wikiMediaToolforgeUrl;
67-
this.wikiMediaTestToolforgeUrl = wikiMediaTestToolforgeUrl;
6865
this.sparqlQueryUrl = sparqlQueryUrl;
6966
this.campaignsUrl = campaignsUrl;
7067
this.gson = gson;
@@ -83,7 +80,7 @@ public OkHttpJsonApiClient(OkHttpClient okHttpClient,
8380
@NonNull
8481
public Observable<LeaderboardResponse> getLeaderboard(String userName, String duration,
8582
String category, String limit, String offset) {
86-
final String fetchLeaderboardUrlTemplate = wikiMediaTestToolforgeUrl
83+
final String fetchLeaderboardUrlTemplate = wikiMediaToolforgeUrl
8784
+ LEADERBOARD_END_POINT;
8885
String url = String.format(Locale.ENGLISH,
8986
fetchLeaderboardUrlTemplate,
@@ -129,7 +126,7 @@ public Observable<LeaderboardResponse> getLeaderboard(String userName, String du
129126
*/
130127
@NonNull
131128
public Single<UpdateAvatarResponse> setAvatar(String username, String avatar) {
132-
final String urlTemplate = wikiMediaTestToolforgeUrl
129+
final String urlTemplate = wikiMediaToolforgeUrl
133130
+ UPDATE_AVATAR_END_POINT;
134131
return Single.fromCallable(() -> {
135132
String url = String.format(Locale.ENGLISH,

0 commit comments

Comments
 (0)