add rule over

Author: walaura

scripts/eslint-rules/__tests__/no-production-logging-test.internal.js

@@ -0,0 +1,60 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @emails react-core
+ */
+
+'use strict';
+
+const rule = require('../no-production-logging');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester();
+
+ruleTester.run("no-production-logging", rule, {
+	valid: [
+		{
+			code: "if (__DEV__) {consoleLog(test)}",
+		},
+		{
+			code: "if (__DEV__) {consoleError(test)}",
+		},
+		{
+			code: "if (__DEV__) { if (potato) { while (true) { consoleError(test) }}}",
+		},
+		{
+			code: "normalFunctionCall(test)",
+		},
+		{
+			code: "if (__DEV__) {normalFunctionCall(test)}",
+		},
+	],
+	invalid: [
+		{
+			code: "consoleLog(test)",
+			errors: [
+				{
+					message: "Wrap consoleLog in a `if (__DEV__)` check",
+				},
+			],
+		},
+		{
+			code: "if (potato) {consoleLog(test)}",
+			errors: [
+				{
+					message: "Wrap consoleLog in a `if (__DEV__)` check",
+				},
+			],
+		},
+		{
+			code: "consoleError(test)",
+			errors: [
+				{
+					message: "Wrap consoleError in a `if (__DEV__)` check",
+				},
+			],
+		},
+	],
+});

scripts/eslint-rules/index.js

@@ -5,5 +5,6 @@ module.exports = {
     'no-primitive-constructors': require('./no-primitive-constructors'),
     'no-to-warn-dev-within-to-throw': require('./no-to-warn-dev-within-to-throw'),
     'warning-and-invariant-args': require('./warning-and-invariant-args'),
+    'no-production-logging': require('./no-production-logging'),
   },
 };

scripts/eslint-rules/no-production-logging.js

@@ -0,0 +1,44 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @emails react-core
+ */
+
+'use strict';
+
+module.exports = function(context) {
+  function hasIfInParents(node) {
+    let done = false;
+    while (!done) {
+      if (!node.parent) {
+        return false;
+      }
+      node = node.parent;
+      if (node.type === 'IfStatement' && node.test.name === '__DEV__') {
+        return true;
+      }
+    }
+  }
+
+  const isLoggerNode = name => ['consoleLog', 'consoleError'].includes(name);
+
+  return {
+    CallExpression: node => {
+      if (!isLoggerNode(node.callee.name)) {
+        return;
+      }
+      if (!hasIfInParents(node)) {
+        context.report({
+          node: node,
+          message: 'Wrap {{identifier}} in a `if (__DEV__)` check',
+          data: {
+            identifier: node.callee.name,
+          },
+        });
+      }
+    },
+  };
+};