Skip to content

Commit 4c7d413

Browse files
committed
C#: Address review comment.
1 parent abf6be6 commit 4c7d413

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

csharp/extractor/Semmle.Extraction.CSharp/Entities/Constructor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public override void WriteId(TextWriter trapFile)
114114
{
115115
if (symbol.IsStatic) trapFile.Write("static");
116116
trapFile.WriteSubId(ContainingType);
117-
AddParametersToId(Context, trapFile, symbol, symbol);
117+
AddParametersToId(Context, trapFile, symbol);
118118
trapFile.Write(";constructor");
119119
}
120120

csharp/extractor/Semmle.Extraction.CSharp/Entities/Method.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ protected static void BuildMethodId(Method m, TextWriter trapFile)
134134
}
135135
}
136136

137-
AddParametersToId(m.Context, trapFile, m.symbol, m.symbol);
137+
AddParametersToId(m.Context, trapFile, m.symbol);
138138
switch (m.symbol.MethodKind)
139139
{
140140
case MethodKind.PropertyGet:
@@ -204,21 +204,21 @@ protected static void AddSignatureTypeToId(Context cx, TextWriter trapFile, IMet
204204
type.BuildTypeId(cx, trapFile, false, symbolBeingDefined, (cx0, tb0, type0, g) => AddSignatureTypeToId(cx, tb0, method, type0, g));
205205
}
206206

207-
protected static void AddParametersToId(Context cx, TextWriter trapFile, IMethodSymbol method, ISymbol symbolBeingDefined)
207+
protected static void AddParametersToId(Context cx, TextWriter trapFile, IMethodSymbol method)
208208
{
209209
trapFile.Write('(');
210210
int index = 0;
211211

212212
if (method.MethodKind == MethodKind.ReducedExtension)
213213
{
214214
trapFile.WriteSeparator(",", ref index);
215-
AddSignatureTypeToId(cx, trapFile, method, method.ReceiverType, symbolBeingDefined);
215+
AddSignatureTypeToId(cx, trapFile, method, method.ReceiverType, method);
216216
}
217217

218218
foreach (var param in method.Parameters)
219219
{
220220
trapFile.WriteSeparator(",", ref index);
221-
AddSignatureTypeToId(cx, trapFile, method, param.Type, symbolBeingDefined);
221+
AddSignatureTypeToId(cx, trapFile, method, param.Type, method);
222222
switch (param.RefKind)
223223
{
224224
case RefKind.Out:

0 commit comments

Comments
 (0)