Python: ObjectAPI to ValueAPI: UselessClass: Adds preliminary modernization

BekaValentine · BekaValentine · commit 8e91f100306d · 2020-04-09T15:25:38.000-07:00
diff --git a/python/ql/src/Classes/UselessClass.ql b/python/ql/src/Classes/UselessClass.ql
@@ -22,9 +22,9 @@ predicate does_not_define_special_method(Class cls) {
 }
 
 predicate no_inheritance(Class c) {
-    not exists(ClassObject cls, ClassObject other |
-        cls.getPyClass() = c and
-        other != theObjectType()
+    not exists(ClassValue cls, ClassValue other |
+        cls.getScope() = c and
+        other != ClassValue::object()
     |
         other.getABaseType() = cls or
         cls.getABaseType() = other

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,9 @@ predicate does_not_define_special_method(Class cls) {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`predicate no_inheritance(Class c) {`
`25`		`- not exists(ClassObject cls, ClassObject other \|`
`26`		`- cls.getPyClass() = c and`
`27`		`- other != theObjectType()`
	`25`	`+ not exists(ClassValue cls, ClassValue other \|`
	`26`	`+ cls.getScope() = c and`
	`27`	`+ other != ClassValue::object()`
`28`	`28`	`\|`
`29`	`29`	`other.getABaseType() = cls or`
`30`	`30`	`cls.getABaseType() = other`