Python: Moves statement out of quantifier that it didnt need to be in

BekaValentine · BekaValentine · commit ce204ac949de · 2020-03-03T14:57:30.000-08:00
diff --git a/python/ql/src/Expressions/WrongNumberArgumentsForFormat.ql b/python/ql/src/Expressions/WrongNumberArgumentsForFormat.ql
@@ -16,7 +16,8 @@ import python
 import semmle.python.strings
 
 predicate string_format(BinaryExpr operation, StrConst str, Value args, AstNode origin) {
-    exists(Value fmt, Context ctx | operation.getOp() instanceof Mod |
+    operation.getOp() instanceof Mod and
+    exists(Value fmt, Context ctx |
            operation.getLeft().pointsTo(ctx, fmt, str) and
            operation.getRight().pointsTo(ctx, args, origin)
     )

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,8 @@ import python`
`16`	`16`	`import semmle.python.strings`
`17`	`17`
`18`	`18`	`predicate string_format(BinaryExpr operation, StrConst str, Value args, AstNode origin) {`
`19`		`- exists(Value fmt, Context ctx \| operation.getOp() instanceof Mod \|`
	`19`	`+ operation.getOp() instanceof Mod and`
	`20`	`+ exists(Value fmt, Context ctx \|`
`20`	`21`	`operation.getLeft().pointsTo(ctx, fmt, str) and`
`21`	`22`	`operation.getRight().pointsTo(ctx, args, origin)`
`22`	`23`	`)`