refactor(library): typings, api surface

Author: xidedix

e2e/src/app.po.ts

@@ -16,7 +16,7 @@ export class AppDashboard {
   getBody() {
     return element(by.xpath('/html/body'));
   }
-  getByCss(selector) {
+  getByCss(selector: string) {
     return element.all(by.css(selector));
   }
 

projects/coreui/angular/src/lib/aside/app-aside.component.ts

@@ -9,8 +9,8 @@ import { asideMenuCssClasses } from '../shared';
 })
 export class AppAsideComponent implements OnInit, OnDestroy {
   @Input() display: any;
-  @Input() fixed: boolean;
-  @Input() offCanvas: boolean;
+  @Input() fixed?: boolean;
+  @Input() offCanvas?: boolean;
 
   private readonly fixedClass = 'aside-menu-fixed';
 
@@ -31,13 +31,13 @@ export class AppAsideComponent implements OnInit, OnDestroy {
     this.renderer.removeClass(this.document.body, this.fixedClass);
   }
 
-  isFixed(fixed: boolean = this.fixed): void {
+  isFixed(fixed = this.fixed): void {
     if (fixed) {
       this.renderer.addClass(this.document.body, this.fixedClass);
     }
   }
 
-  isOffCanvas(offCanvas: boolean = this.offCanvas): void {
+  isOffCanvas(offCanvas = this.offCanvas): void {
     if (offCanvas) {
       this.renderer.addClass(this.document.body, 'aside-menu-off-canvas');
     }

projects/coreui/angular/src/lib/aside/app-aside.module.ts

@@ -10,8 +10,7 @@ import { AppAsideComponent } from './app-aside.component';
     LayoutModule
   ],
   exports: [
-    AppAsideComponent,
-    LayoutModule
+    AppAsideComponent
   ],
   declarations: [
     AppAsideComponent

projects/coreui/angular/src/lib/breadcrumb/app-breadcrumb.component.ts

@@ -3,6 +3,7 @@ import {DOCUMENT} from '@angular/common';
 
 import {AppBreadcrumbService} from './app-breadcrumb.service';
 import {Replace} from '../shared';
+import { Observable } from 'rxjs';
 
 @Component({
   selector: 'app-breadcrumb',
@@ -18,8 +19,8 @@ import {Replace} from '../shared';
   `
 })
 export class AppBreadcrumbComponent implements OnInit, OnDestroy {
-  @Input() fixed: boolean;
-  public breadcrumbs;
+  @Input() fixed?: boolean;
+  public breadcrumbs?: Observable<any>;
   private readonly fixedClass = 'breadcrumb-fixed';
 
   constructor(
@@ -39,7 +40,7 @@ export class AppBreadcrumbComponent implements OnInit, OnDestroy {
     this.renderer.removeClass(this.document.body, this.fixedClass);
   }
 
-  isFixed(fixed: boolean = this.fixed): void {
+  isFixed(fixed = this.fixed): void {
     if (fixed) {
       this.renderer.addClass(this.document.body, this.fixedClass);
     }

projects/coreui/angular/src/lib/breadcrumb/app-breadcrumb.service.ts

@@ -20,8 +20,8 @@ export class AppBreadcrumbService {
     this.breadcrumbs = this.breadcrumbSubject.asObservable();
 
     this.router.events.pipe(filter(event => event instanceof NavigationEnd)).subscribe((event) => {
-      const breadcrumbs = [];
-      let currentRoute = this.route.root;
+      const breadcrumbs: any[] = [];
+      let currentRoute: ActivatedRoute | null = this.route.root;
       let url = '';
       do {
         const childrenRoutes = currentRoute.children;

projects/coreui/angular/src/lib/breadcrumb/cui-breadcrumb.component.ts

@@ -2,16 +2,17 @@ import {Component, ElementRef, Inject, Input, OnDestroy, OnInit, Renderer2} from
 import {DOCUMENT} from '@angular/common';
 
 import {AppBreadcrumbService} from './app-breadcrumb.service';
+import { Observable } from 'rxjs';
 
 @Component({
   // tslint:disable-next-line:component-selector
   selector: 'cui-breadcrumb',
   templateUrl: './cui-breadcrumb.component.html'
 })
 export class CuiBreadcrumbComponent implements OnInit, OnDestroy {
-  @Input() fixed: boolean;
+  @Input() fixed?: boolean;
 
-  public breadcrumbs;
+  public breadcrumbs?: Observable<any[]>;
   private readonly fixedClass = 'breadcrumb-fixed';
 
   constructor(
@@ -29,7 +30,7 @@ export class CuiBreadcrumbComponent implements OnInit, OnDestroy {
     this.renderer.removeClass(this.document.body, this.fixedClass);
   }
 
-  isFixed(fixed: boolean = this.fixed): void {
+  isFixed(fixed = this.fixed): void {
     if (fixed) {
       this.renderer.addClass(this.document.body, this.fixedClass);
     }

projects/coreui/angular/src/lib/footer/app-footer.component.ts

@@ -6,7 +6,7 @@ import {DOCUMENT} from '@angular/common';
   template: `<ng-content></ng-content>`
 })
 export class AppFooterComponent implements OnInit, OnDestroy {
-  @Input() fixed: boolean;
+  @Input() fixed?: boolean;
 
   private readonly fixedClass = 'footer-fixed';
 
@@ -25,7 +25,7 @@ export class AppFooterComponent implements OnInit, OnDestroy {
     this.renderer.removeClass(this.document.body, this.fixedClass);
   }
 
-  isFixed(fixed: boolean = this.fixed): void {
+  isFixed(fixed = this.fixed): void {
     if (fixed) {
       this.renderer.addClass(this.document.body, this.fixedClass);
     }

projects/coreui/angular/src/lib/header/app-header.component.ts

@@ -7,27 +7,27 @@ import { DOCUMENT } from '@angular/common';
 })
 export class AppHeaderComponent implements OnInit, OnDestroy {
 
-  @Input() fixed: boolean;
+  @Input() fixed?: boolean;
 
   @Input() navbarBrand: any;
   @Input() navbarBrandFull: any;
   @Input() navbarBrandMinimized: any;
   @Input() navbarBrandText: any = {icon: '🅲', text: '🅲 CoreUI'};
-  @Input() navbarBrandHref: ''; // deprecated, use navbarBrandRouterLink instead
+  @Input() navbarBrandHref = ''; // deprecated, use navbarBrandRouterLink instead
   @Input() navbarBrandRouterLink: any[] | string = '';
 
-  @Input() sidebarToggler: string | boolean;
-  @Input() mobileSidebarToggler: boolean;
+  @Input() sidebarToggler: string | boolean = 'lg';
+  @Input() mobileSidebarToggler = true;
 
-  @Input() asideMenuToggler: string | boolean;
-  @Input() mobileAsideMenuToggler: boolean;
+  @Input() asideMenuToggler: string | boolean = 'lg';
+  @Input() mobileAsideMenuToggler = true;
 
   private readonly fixedClass = 'header-fixed';
 
   @HostBinding('class.app-header') appHeaderClass = true;
   @HostBinding('class.navbar') navbarClass = true;
 
-  navbarBrandImg: boolean;
+  navbarBrandImg!: boolean;
 
   private readonly breakpoints = ['xl', 'lg', 'md', 'sm', 'xs'];
   sidebarTogglerClass = 'd-none d-md-block';
@@ -44,23 +44,23 @@ export class AppHeaderComponent implements OnInit, OnDestroy {
     this.isFixed(this.fixed);
     this.navbarBrandImg = Boolean(this.navbarBrand || this.navbarBrandFull || this.navbarBrandMinimized);
     this.navbarBrandRouterLink = this.navbarBrandRouterLink[0] ? this.navbarBrandRouterLink : this.navbarBrandHref;
-    this.sidebarTogglerClass = this.setToggerBreakpointClass(this.sidebarToggler as string);
-    this.sidebarTogglerMobileClass = this.setToggerMobileBreakpointClass(this.sidebarToggler as string);
-    this.asideTogglerClass = this.setToggerBreakpointClass(this.asideMenuToggler as string);
-    this.asideTogglerMobileClass = this.setToggerMobileBreakpointClass(this.asideMenuToggler as string);
+    this.sidebarTogglerClass = this.setTogglerBreakpointClass(this.sidebarToggler as string);
+    this.sidebarTogglerMobileClass = this.setTogglerMobileBreakpointClass(this.sidebarToggler as string);
+    this.asideTogglerClass = this.setTogglerBreakpointClass(this.asideMenuToggler as string);
+    this.asideTogglerMobileClass = this.setTogglerMobileBreakpointClass(this.asideMenuToggler as string);
   }
 
   ngOnDestroy(): void {
     this.renderer.removeClass(this.document.body, this.fixedClass);
   }
 
-  isFixed(fixed: boolean = this.fixed): void {
+  isFixed(fixed = this.fixed): void {
     if (fixed) {
       this.renderer.addClass(this.document.body, this.fixedClass);
     }
   }
 
-  setToggerBreakpointClass(breakpoint = 'md') {
+  setTogglerBreakpointClass(breakpoint = 'md') {
     let togglerClass = 'd-none d-md-block';
     if (this.breakpoints.includes(breakpoint)) {
       const breakpointIndex = this.breakpoints.indexOf(breakpoint);
@@ -69,7 +69,7 @@ export class AppHeaderComponent implements OnInit, OnDestroy {
     return togglerClass;
   }
 
-  setToggerMobileBreakpointClass(breakpoint = 'lg') {
+  setTogglerMobileBreakpointClass(breakpoint = 'lg') {
     let togglerClass = 'd-lg-none';
     if (this.breakpoints.includes(breakpoint)) {
       togglerClass = `d-${breakpoint}-none`;

projects/coreui/angular/src/lib/header/app-header.module.ts

@@ -13,7 +13,6 @@ import { AppHeaderComponent } from './app-header.component';
   ],
   exports: [
     AppHeaderComponent,
-    LayoutModule
   ],
   declarations: [
     AppHeaderComponent

projects/coreui/angular/src/lib/shared/index.ts

@@ -1,3 +1 @@
-export * from './classes';
-export * from './layout/index';
-export * from './replace';
+export * from './public_api';