Handle invalid links and empty responds bodies #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and I almost completely forgot to mention. I am a complete noob when it comes to node.js, so I gladly welcome any critique, comments, or questions about my work, both in this pull request and any pull requests in the future. |
|
Awesome! Thank you, Joseph :) I'd love to see more pull requests from you. |
ecdeveloper
pushed a commit
that referenced
this pull request
Jul 20, 2013
Handle invalid links and empty responds bodies
|
Good stuff @josephdpurcell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code fixes in 147abbc were required for me to crawl sites that have invalid links or links to URLs with empty response bodies without killing node. The solution I implemented was to ignore the links that are invalid and links that have empty response bodies. I don't know if that is the best behavior, but first and foremost I think it is important that the code work out of the box.
In addition, this upgrades jQuery to v1.9 and Bootstrap to the latest, v2.3.2. (Not sure how you feel about upgrading those, if you don't think it's a good idea for some reason please let me know.)