Feature: Added option to filter items when typing #17339
Conversation
yaira2
changed the title
yaira2
force-pushed
the
ya/FilterBinding
branch
7 times, most recently
from
d0c7ce5 to
4b76218
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
yaira2
force-pushed
the
ya/FilterBinding
branch
2 times, most recently
from
10d306e to
5afb917
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new keyboard typing behavior option to filter items in the file area instead of jumping to files. Users can now choose between "Jump to file" (existing behavior) and "Filter items" (new behavior) in the Advanced settings page.
Key changes:
- Added a new
KeyboardTypingBehaviorenum withJumpToFileandFilterItemsoptions - Replaced character-based input handling with key-based input to support filtering
- Integrated filter functionality with the existing filter header UI
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| KeyboardTypingBehavior.cs | New enum defining the two typing behaviors |
| IFoldersSettingsService.cs | Added property for keyboard typing behavior setting |
| FoldersSettingsService.cs | Implementation of the keyboard typing behavior setting |
| AdvancedViewModel.cs | Added UI binding for the new setting in Advanced page |
| AdvancedPage.xaml | Added settings card for keyboard typing behavior selection |
| BaseLayoutPage.cs | Replaced character input handler with key preview handler to support filtering |
| BaseGroupableLayoutPage.cs | Updated to use the new key preview handler |
| ShellViewModel.cs | Added automatic filter application and clearing logic |
| ModernShellPage.xaml.cs | Removed manual filter handling in favor of data binding |
| ModernShellPage.xaml | Changed to use two-way data binding for the filter text box |
| MainPage.xaml.cs | Added special handling for Back/Space keys in filter mode |
| FilesystemHelpers.cs | Updated restricted characters logic to use Path.GetInvalidFileNameChars() |
| ToggleFilterHeaderAction.cs | Added filter clearing when header is hidden |
| Resources.resw | Added localized strings for the new feature |
yaira2
force-pushed
the
ya/FilterBinding
branch
from
5afb917 to
21baf6c
Compare
|
This feature raises some UX concerns, as it allows text input without the text box being focused. Auto focusing the text box on keypress could resolve this, but it would undermine the features purpose (allowing users to filter while staying focused on the file list), given that users can already activate the filter header via shortcut. |
|
We did discuss displaying user text input as an overlay, which we could do for the initial filter - further changes to the filter text could be done from the TextBox on the filter header. |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.