More tests for Promise listeners that throw errors

Author: cpettitt-linkedin

test/com/linkedin/parseq/promise/TestSettablePromise.java

@@ -344,7 +344,6 @@ public void onResolved(Promise<String> promise)
     assertEquals("Done!", promise.get());
   }
 
-
   @Test
   public void testListenerThrowsError() throws InterruptedException
   {
@@ -364,4 +363,24 @@ public void onResolved(Promise<String> promise)
     assertTrue(promise.await(5, TimeUnit.SECONDS));
     assertEquals("Done!", promise.get());
   }
+
+  @Test
+  public void testListenerThrowsErrorAfterPromiseDone() throws InterruptedException
+  {
+    // This test ensures that we catch and do not rethrow errors from listeners
+    // even if they are added after the promise is done.
+    final SettablePromise<String> promise = Promises.settable();
+    promise.done("Done!");
+    assertTrue(promise.await(5, TimeUnit.SECONDS));
+
+    // This should not throw
+    promise.addListener(new PromiseListener<String>()
+    {
+      @Override
+      public void onResolved(Promise<String> promise)
+      {
+        throw new Error();
+      }
+    });
+  }
 }