Lift code for hiding system tasks

Author: cpettitt-linkedin

src/com/linkedin/parseq/ParTaskImpl.java

@@ -17,6 +17,7 @@
 package com.linkedin.parseq;
 
 import com.linkedin.parseq.internal.InternalUtil;
+import com.linkedin.parseq.internal.SystemHiddenTask;
 import com.linkedin.parseq.promise.Promise;
 import com.linkedin.parseq.promise.PromiseListener;
 import com.linkedin.parseq.promise.Promises;
@@ -38,7 +39,7 @@
  * @author Chris Pettitt ([email protected])
  * @author Chi Chan ([email protected])
  */
-/* package private */ class ParTaskImpl<T> extends BaseTask<List<T>> implements ParTask<T>
+/* package private */ class ParTaskImpl<T> extends SystemHiddenTask<List<T>> implements ParTask<T>
 {
   private final List<Task<T>> _tasks;
 
@@ -137,13 +138,4 @@ public List<T> getSuccessful()
     }
     return taskResult;
   }
-
-  @Override
-  public ShallowTrace getShallowTrace()
-  {
-    ShallowTrace shallowTrace = super.getShallowTrace();
-    ShallowTraceBuilder builder = new ShallowTraceBuilder(shallowTrace);
-    builder.setSystemHidden(true);
-    return builder.build();
-  }
 }

src/com/linkedin/parseq/SeqTask.java

@@ -16,6 +16,7 @@
 
 package com.linkedin.parseq;
 
+import com.linkedin.parseq.internal.SystemHiddenTask;
 import com.linkedin.parseq.promise.Promise;
 import com.linkedin.parseq.promise.Promises;
 import com.linkedin.parseq.promise.SettablePromise;
@@ -35,7 +36,7 @@
  * @author Chris Pettitt ([email protected])
  * @author Chi Chan ([email protected])
  */
-/* package private */ class SeqTask<T> extends BaseTask<T>
+/* package private */ class SeqTask<T> extends SystemHiddenTask<T>
 {
   private final List<Task<?>> _tasks;
 
@@ -78,13 +79,4 @@ protected Promise<? extends T> run(final Context context) throws Exception
     context.run(_tasks.get(0));
     return result;
   }
-
-  @Override
-  public ShallowTrace getShallowTrace()
-  {
-    ShallowTrace shallowTrace = super.getShallowTrace();
-    ShallowTraceBuilder builder = new ShallowTraceBuilder(shallowTrace);
-    builder.setSystemHidden(true);
-    return builder.build();
-  }
 }

src/com/linkedin/parseq/internal/SystemHiddenTask.java

@@ -0,0 +1,21 @@
+package com.linkedin.parseq.internal;
+
+import com.linkedin.parseq.BaseTask;
+import com.linkedin.parseq.trace.ShallowTrace;
+import com.linkedin.parseq.trace.ShallowTraceBuilder;
+
+public abstract class SystemHiddenTask<T> extends BaseTask<T>
+{
+  protected SystemHiddenTask(String name)
+  {
+    super(name);
+  }
+
+  @Override
+  public ShallowTrace getShallowTrace()
+  {
+    return new ShallowTraceBuilder(super.getShallowTrace())
+        .setSystemHidden(true)
+        .build();
+  }
+}

test/com/linkedin/parseq/TestParTask.java

@@ -622,4 +622,11 @@ public void testPar10() throws InterruptedException
     assertTrue(par.await(5, TimeUnit.SECONDS));
     assertEquals(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10), par.get());
   }
+
+  @Test
+  public void testParIsSystemHidden()
+  {
+    final ParTask<String> par = par(Collections.singleton(value("value")));
+    assertTrue(par.getShallowTrace().getSystemHidden());
+  }
 }

test/com/linkedin/parseq/TestSeqTask.java

@@ -215,4 +215,5 @@ public void testSeq10() throws InterruptedException
     assertTrue(seq.await(5, TimeUnit.SECONDS));
     assertEquals("result", seq.get());
   }
+
 }