Return undefined in most cases to support noImplicitReturns rule

Filter out wrong enum values

(cherry picked from commit 05d5962)

Author: ferdikoomen

src/openApi/v3/parser/getEnum.ts

@@ -1,13 +1,14 @@
 import type { Enum } from '../../../client/interfaces/Enum';
-import { isDefined } from '../../../utils/isDefined';
 
 export function getEnum(values?: (string | number)[]): Enum[] {
     if (Array.isArray(values)) {
         return values
             .filter((value, index, arr) => {
                 return arr.indexOf(value) === index;
             })
-            .filter(isDefined)
+            .filter((value: any) => {
+                return typeof value === 'number' || typeof value === 'string';
+            })
             .map(value => {
                 if (typeof value === 'number') {
                     return {
@@ -23,7 +24,7 @@ export function getEnum(values?: (string | number)[]): Enum[] {
                         .replace(/^(\d+)/g, '_$1')
                         .replace(/([a-z])([A-Z]+)/g, '$1_$2')
                         .toUpperCase(),
-                    value: `'${value}'`,
+                    value: `'${value.replace(/'/g, "\\'")}'`,
                     type: 'string',
                     description: null,
                 };

src/openApi/v3/parser/getModelDefault.ts

@@ -3,7 +3,7 @@ import type { OpenApiSchema } from '../interfaces/OpenApiSchema';
 
 export function getModelDefault(definition: OpenApiSchema, model?: Model): string | undefined {
     if (definition.default === undefined) {
-        return;
+        return undefined;
     }
 
     if (definition.default === null) {
@@ -35,5 +35,5 @@ export function getModelDefault(definition: OpenApiSchema, model?: Model): strin
             }
     }
 
-    return;
+    return undefined;
 }

src/templates/core/axios/getRequestBody.hbs

@@ -1,6 +1,6 @@
-function getRequestBody(options: ApiRequestOptions): any {
-    if (options.body) {
-        return options.body;
-    }
-    return;
-}
+const getRequestBody = (options: ApiRequestOptions): any => {
+	if (options.body) {
+		return options.body;
+	}
+	return undefined;
+};

src/templates/core/axios/getResponseBody.hbs

@@ -1,6 +1,6 @@
-function getResponseBody(response: AxiosResponse<any>): any {
-    if (response.status !== 204) {
-        return response.data;
-    }
-    return;
-}
+const getResponseBody = (response: AxiosResponse<any>): any => {
+	if (response.status !== 204) {
+		return response.data;
+	}
+	return undefined;
+};

src/utils/discriminator.ts

@@ -27,7 +27,7 @@ export function findOneOfParentDiscriminator(openApi: OpenApi, parent?: Model):
             }
         }
     }
-    return;
+    return undefined;
 }
 
 export function mapPropertyValue(discriminator: OpenApiDiscriminator, parent: Model): string {