Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Adds link to json-schema-to-elm in implementations.md #266

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Adds link to json-schema-to-elm in implementations.md #266

merged 2 commits into from
Aug 14, 2019

Conversation

dragonwasrobot
Copy link
Contributor

Adds a link to the json-schema-to-elm project in implementations.md.

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if your project readme could specify which versions of JSON Schema it supports. Then I'll feel more able to approve and merge your request.

Thanks for your hard work =]

@Anthropic
Copy link
Contributor

Anthropic commented Aug 13, 2019

@dragonwasrobot I tried to check version for you on your project but as far as I can tell it supports draft 4 so far, is that correct? If you can add a *supports Draft x* to the end of the line or at least confirm the version here so I can add it for you that'd be great, sorry no one noticed this PR for so long! I should mention that drafts prior to 6 will be moved to the obsolete-implementations file, so the more recent the draft support the better.

@dragonwasrobot
Copy link
Contributor Author

dragonwasrobot commented Aug 13, 2019

Hi, it currently only supports draft v7 (to avoid handling backwards-compatibility issues). I've made this more clear in the README of json-schema-to-elm and added to the description in the pull request.

@Anthropic Anthropic merged commit b99ca52 into json-schema-org:master Aug 14, 2019
@dragonwasrobot dragonwasrobot deleted the add-js2e-link branch August 14, 2019 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants