Skip to content

[GVN] Handle not in equality propagation #151942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions llvm/lib/Transforms/Scalar/GVN.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2683,6 +2683,11 @@ bool GVNPass::propagateEquality(Value *LHS, Value *RHS,
Worklist.emplace_back(A, ConstantInt::get(A->getType(), IsKnownTrue));
continue;
}

if (match(LHS, m_Not(m_Value(A)))) {
Worklist.emplace_back(A, ConstantInt::get(A->getType(), !IsKnownTrue));
continue;
}
}

return Changed;
Expand Down
82 changes: 82 additions & 0 deletions llvm/test/Transforms/GVN/condprop.ll
Original file line number Diff line number Diff line change
Expand Up @@ -999,5 +999,87 @@ loop.latch:
br label %loop
}

define i1 @not_cond(i1 %c) {
; CHECK-LABEL: @not_cond(
; CHECK-NEXT: [[C_NOT:%.*]] = xor i1 [[C:%.*]], true
; CHECK-NEXT: br i1 [[C_NOT]], label [[IF:%.*]], label [[ELSE:%.*]]
; CHECK: if:
; CHECK-NEXT: ret i1 false
; CHECK: else:
; CHECK-NEXT: ret i1 true
;
%c.not = xor i1 %c, true
br i1 %c.not, label %if, label %else

if:
ret i1 %c

else:
ret i1 %c
}

define i32 @not_cond_icmp(i32 %x) {
; CHECK-LABEL: @not_cond_icmp(
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[X:%.*]], 42
; CHECK-NEXT: [[CMP_NOT:%.*]] = xor i1 [[CMP]], true
; CHECK-NEXT: br i1 [[CMP_NOT]], label [[IF:%.*]], label [[ELSE:%.*]]
; CHECK: if:
; CHECK-NEXT: ret i32 [[X]]
; CHECK: else:
; CHECK-NEXT: ret i32 42
;
%cmp = icmp eq i32 %x, 42
%cmp.not = xor i1 %cmp, true
br i1 %cmp.not, label %if, label %else

if:
ret i32 %x

else:
ret i32 %x
}

define i1 @not_cond_logic1(i1 %c, i1 %d) {
; CHECK-LABEL: @not_cond_logic1(
; CHECK-NEXT: [[C_NOT:%.*]] = xor i1 [[C:%.*]], true
; CHECK-NEXT: [[AND:%.*]] = and i1 [[C_NOT]], [[D:%.*]]
; CHECK-NEXT: br i1 [[AND]], label [[IF:%.*]], label [[ELSE:%.*]]
; CHECK: if:
; CHECK-NEXT: ret i1 false
; CHECK: else:
; CHECK-NEXT: ret i1 [[C]]
;
%c.not = xor i1 %c, true
%and = and i1 %c.not, %d
br i1 %and, label %if, label %else

if:
ret i1 %c

else:
ret i1 %c
}

define i1 @not_cond_logic2(i1 %c, i1 %d) {
; CHECK-LABEL: @not_cond_logic2(
; CHECK-NEXT: [[C_NOT:%.*]] = xor i1 [[C:%.*]], true
; CHECK-NEXT: [[AND:%.*]] = or i1 [[C_NOT]], [[D:%.*]]
; CHECK-NEXT: br i1 [[AND]], label [[IF:%.*]], label [[ELSE:%.*]]
; CHECK: if:
; CHECK-NEXT: ret i1 [[C]]
; CHECK: else:
; CHECK-NEXT: ret i1 true
;
%c.not = xor i1 %c, true
%or = or i1 %c.not, %d
br i1 %or, label %if, label %else

if:
ret i1 %c

else:
ret i1 %c
}

declare void @use_bool(i1)
declare void @use_ptr(ptr)
Loading