Updated base image to be from scratch instead of alpine #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added post-build check to guarantee statically linked binary Updated builder container to use golang:1.20.5 Changed CMD to ENTRYPOINT as this is a single executable container with no arguments Updated Makefile to setup a build multi-arch docker system if desired and TAG default to 1.9 Updated the docker buildx command to generate an sbom during build. Added .gitignore
Closed
|
@nathanmcgarvey-modopayments changing the base image has been sitting untouched on my to-do list for far too long, having looked over the code again it looks like |
max-rocket-internet
approved these changes
Jun 21, 2023
I've enabled it just now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added post-build check to guarantee statically linked binary
Updated builder container to use golang:1.20.5
Changed CMD to ENTRYPOINT as this is a single executable container with no arguments
Updated Makefile to setup a build multi-arch docker system if desired and TAG default to 1.9
Updated the docker buildx command to generate an sbom during build.
Added .gitignore