Better kubernetes configuration detection based on k8s libraries #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig, use the k8s.io/cmdclient built-in methods which support KUBECONFIG env variable, $HOME/.kube/config, and KUBERNETES_SERVICE env variables automatically. Also print out a sanitized representation of the config at startup in case of misconfiguration.
|
Now that I'm looking at it, why are these variables being set in the helm chart? Those should get picked up by default (I haven't tested, but it should) Edit: at least in my local cluster, those variables are not necessary at all. Removed in the next commit. |
…ontainer securityContext configurable via variables instead of hard-coded
When that code was written about 4 years ago this was not the case but a lot has changed since 😅 |
Give me a couple days and I'll test it. |
max-rocket-internet
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Tested locally and in AWS EKS, LGTM ✅
Thanks @nathanmcgarvey-modopayments 💖
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test this locally (go run ./main.go) and in a k8s cluster both with a .kube/config with no KUBECONFIG env variable set and one with a KUBECONFIG env variable set before merging. It works for me, but I want to ensure it doesn't break anyone.
Instead of doing our own user home directory detection for .kube/config, use the k8s.io/cmdclient built-in methods which support KUBECONFIG env variable, $HOME/.kube/config, and KUBERNETES_SERVICE env variables automatically.
Also print out a sanitized representation of the config at startup in case of misconfiguration.