Skip to content

Allow filtering out normal events #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mmckeen
Copy link
Contributor

@mmckeen mmckeen commented Jun 27, 2023

Description

Normal events can often be noisy, and for many use cases all we care about is Warning events.

That said, add the ability to only report non-normal events via a flag.

Testing

Tested using a kube cluster, works as expected.

Copy link
Owner

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, thanks @mmckeen 💙

This is the first "feature" on this project though, I wonder if we should include a test 🤔

@max-rocket-internet max-rocket-internet merged commit a12102d into max-rocket-internet:master Jul 6, 2023
@mmckeen
Copy link
Contributor Author

mmckeen commented Jul 6, 2023

@max-rocket-internet let me file an issue for test coverage, I also have a few other feature-requests/ideas I'll file into the backlog 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants