Merge branch 'AJIXuMuK-116' into dev

Author: estruyf

CHANGELOG.JSON

@@ -5,21 +5,22 @@
       "changes": {
         "new": [],
         "enhancements": [
-          "`PeoplePicker`: ability to specify the source site to load users from [#110](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/110)",
           "`PeoplePicker`: Specify to hide or show the users/groups which are hidden in the UI [#122](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/122)",
-          "`PeoplePicker`: Specify principle type to retrieve (users, groups, ...) [#122](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/122)",
           "`WebPartTitle`: changing font-sizes on different resolutions [#114](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/114)",
           "`WebPartTitle`: Added accessibility tags for web part title [#121](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/121)",
           "`ListView`: Resizable columns - introduced a `isResizable` property [#119](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/119)",
+          "`FieldNameRenderer` double click support added [#116](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/116)",
           "`TaxonomyPicker`: table markup changed to DIV [#113](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/113)",
-          "`TaxonomyPicker`: Disable the terms which are set as deprecated or unavailable for tagging [#109](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/109)"
+          "`PeoplePicker`: ability to specify the source site to load users from [#110](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/110)",
+          "`TaxonomyPicker`: Disable the terms which are set as deprecated or unavailable for tagging [#109](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/109)",
+          "`PeoplePicker`: Specify principle type to retrieve (users, groups, ...) [#94](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/94)"
         ],
         "fixes": [
           "`IFrameDialog`: dialog width is not correct in IE11 [#118](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/118)",
           "`PeoplePicker`: fix freezes when typing in search values [#117](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/117)"
         ]
       },
-      "contributions": ["[Thomas Lamb](https://github.com/ThomasLamb)", "[Joel Rodrigues](https://github.com/joelfmrodrigues)", "[Mikael Svenson](https://github.com/wobba)"]
+      "contributions": ["[Thomas Lamb](https://github.com/ThomasLamb)", "[Joel Rodrigues](https://github.com/joelfmrodrigues)", "[Mikael Svenson](https://github.com/wobba)", "[Alex Terentiev](https://github.com/AJIXuMuK)"]
     },
     {
       "version": "1.7.0",

docs/documentation/docs/controls/fields/FieldNameRenderer.md

@@ -37,9 +37,9 @@ The FieldNameRenderer component can be configured with the following properties:
 | isLink | boolean | yes | True if the name should be rendered as a link. |
 | isNew | boolean | no | True if the document is new. |
 | filePath | string | no | Path to the document. |
-| hasPreview | boolean | no | True if the document has preview (true by default) |
-| onClick | (args: INameClickEventArgs) => {} | no | Custom handler for link click. If not set link click will lead to rendering document preview. |
-
+| hasPreview | boolean | no | True if the document has preview and link href should be constructed to display the preview (instead of direct document's link). The flag works only if `onClick` property is NOT defined.  |
+| onClick | (args: INameClickEventArgs) => {} | no | Custom handler for link click. If not set link click will lead to rendering document preview. Works if `isLink` is set to `true` |
+| onDoubleClick | (args: INameClickEventArgs) => {} | no | Custom handler for link double click. If not set link If not set link will use OOTB behavior. Works if `isLink` is set to `true`  |
 
 ![](https://telemetry.sharepointpnp.com/sp-dev-fx-controls-react/wiki/controls/fields/FieldNameRenderer)
 

src/controls/fields/fieldNameRenderer/FieldNameRenderer.tsx

@@ -1,5 +1,7 @@
 import { override } from '@microsoft/decorators';
 import * as React from 'react';
+import * as ReactDOM from 'react-dom';
+
 import { css } from 'office-ui-fabric-react/lib/Utilities';
 import { Icon } from 'office-ui-fabric-react/lib/Icon';
 import { Link } from 'office-ui-fabric-react/lib/Link';
@@ -28,13 +30,20 @@ export interface IFieldNameRendererProps extends IFieldRendererProps {
      */
     isNew?: boolean;
     /**
-     * true if the document type has preview (true by default)
+     * true if the document type has preview (true by default).
+     * The flag impacts on the link's href: 
+     * if the flag is tru then the href is constructed like #id=${filePath}&parent=${filePath.substring(0, filePath.lastIndexOf('/'))},
+     * otherwise the href will contain filePath only.
      */
     hasPreview?: boolean;
     /**
      * custom handler for link click. If not set link click will lead to rendering document preview
      */
     onClick?: (args: IFieldNameClickEventArgs) => {};
+    /**
+     * custom handler for link double click. If not set link will use OOTB behavior.
+     */
+    onDoubleClick?: (args: IFieldNameClickEventArgs) => {};
 }
 
 /**
@@ -57,12 +66,37 @@ export interface IFieldNameClickEventArgs {
  *   - Title
  */
 export class FieldNameRenderer extends React.Component<IFieldNameRendererProps, IFieldNameRendererState> {
+    private _button: HTMLButtonElement;
+
     public constructor(props: IFieldNameRendererProps, state: IFieldNameRendererState) {
         super(props, state);
 
         telemetry.track('FieldNameRenderer', {});
 
         this.state = {};
+
+        this._onDoubleClick = this._onDoubleClick.bind(this);
+    }
+
+    @override
+    public componentDidMount() {
+        //
+        // small hack for double click.
+        // unfortunately, we can't use React onDoubleClick because React doesn't guaranty the sequence of handlers.
+        // And stopPropagation could not make effect.
+        //
+        if (this.props.onDoubleClick && this.props.isLink) {
+            const domNode = ReactDOM.findDOMNode(this);
+            this._button = domNode.querySelector('button');
+            this._button.addEventListener('dblclick', this._onDoubleClick, false);
+        }
+    }
+
+    @override
+    public componentWillUnmount() {
+        if (this._button) {
+            this._button.removeEventListener('dblclick', this._onDoubleClick);
+        }
     }
 
     @override
@@ -76,7 +110,10 @@ export class FieldNameRenderer extends React.Component<IFieldNameRendererProps,
 
         if (isLink) {
             if (this.props.onClick) {
-                value = <Link onClick={this._onClick.bind(this)} style={this.props.cssProps} className={styles.value}>{this.props.text}</Link>;
+                value = <Link
+                    onClick={this._onClick.bind(this)}
+                    style={this.props.cssProps}
+                    className={styles.value}>{this.props.text}</Link>;
             }
             else {
                 let url: string;
@@ -103,13 +140,23 @@ export class FieldNameRenderer extends React.Component<IFieldNameRendererProps,
         </span>;
     }
 
-    private _onClick(e): void {
+    private _onClick(e): boolean {
         if (this.props.onClick) {
             e.stopPropagation();
             e.preventDefault();
             const args: IFieldNameClickEventArgs = this.props as IFieldNameClickEventArgs;
             this.props.onClick(args);
-            return;
+            return false;
+        }
+    }
+
+    private _onDoubleClick(e): boolean {
+        if (this.props.onDoubleClick) {
+            e.stopPropagation();
+            e.preventDefault();
+            const args: IFieldNameClickEventArgs = this.props as IFieldNameClickEventArgs;
+            this.props.onDoubleClick(args);
+            return false;
         }
     }
 }