Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 186513d

Browse files
Andrew Gilbertsebastianbergmann
authored andcommitted
Omit unnecessary operations
When disableIgnoredLines is set, there's no reason to open the file just to return an empty array.
1 parent 1a6c7ee commit 186513d

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/CodeCoverage.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -671,15 +671,16 @@ private function getLinesToBeIgnored($filename)
671671

672672
if (!isset($this->ignoredLines[$filename])) {
673673
$this->ignoredLines[$filename] = array();
674-
$ignore = false;
675-
$stop = false;
676-
$lines = file($filename);
677-
$numLines = count($lines);
678674

679675
if ($this->disableIgnoredLines) {
680676
return $this->ignoredLines[$filename];
681677
}
682678

679+
$ignore = false;
680+
$stop = false;
681+
$lines = file($filename);
682+
$numLines = count($lines);
683+
683684
foreach ($lines as $index => $line) {
684685
if (!trim($line)) {
685686
$this->ignoredLines[$filename][] = $index + 1;

0 commit comments

Comments
 (0)