Skip to content

Commit 3101c04

Browse files
Make methods private
1 parent 96bb00c commit 3101c04

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

src/Report/Html/Renderer/Dashboard.php

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,19 @@ public function render(DirectoryNode $node, string $file): void
5555
$template->renderTo($file);
5656
}
5757

58+
protected function activeBreadcrumb(AbstractNode $node): string
59+
{
60+
return \sprintf(
61+
' <li class="breadcrumb-item"><a href="index.html">%s</a></li>' . "\n" .
62+
' <li class="breadcrumb-item active">(Dashboard)</li>' . "\n",
63+
$node->name()
64+
);
65+
}
66+
5867
/**
5968
* Returns the data for the Class/Method Complexity charts.
6069
*/
61-
protected function complexity(array $classes, string $baseLink): array
70+
private function complexity(array $classes, string $baseLink): array
6271
{
6372
$result = ['class' => [], 'method' => []];
6473

@@ -99,7 +108,7 @@ protected function complexity(array $classes, string $baseLink): array
99108
/**
100109
* Returns the data for the Class / Method Coverage Distribution chart.
101110
*/
102-
protected function coverageDistribution(array $classes): array
111+
private function coverageDistribution(array $classes): array
103112
{
104113
$result = [
105114
'class' => [
@@ -165,7 +174,7 @@ protected function coverageDistribution(array $classes): array
165174
/**
166175
* Returns the classes / methods with insufficient coverage.
167176
*/
168-
protected function insufficientCoverage(array $classes, string $baseLink): array
177+
private function insufficientCoverage(array $classes, string $baseLink): array
169178
{
170179
$leastTestedClasses = [];
171180
$leastTestedMethods = [];
@@ -219,7 +228,7 @@ protected function insufficientCoverage(array $classes, string $baseLink): array
219228
/**
220229
* Returns the project risks according to the CRAP index.
221230
*/
222-
protected function projectRisks(array $classes, string $baseLink): array
231+
private function projectRisks(array $classes, string $baseLink): array
223232
{
224233
$classRisks = [];
225234
$methodRisks = [];
@@ -270,13 +279,4 @@ protected function projectRisks(array $classes, string $baseLink): array
270279

271280
return $result;
272281
}
273-
274-
protected function activeBreadcrumb(AbstractNode $node): string
275-
{
276-
return \sprintf(
277-
' <li class="breadcrumb-item"><a href="index.html">%s</a></li>' . "\n" .
278-
' <li class="breadcrumb-item active">(Dashboard)</li>' . "\n",
279-
$node->name()
280-
);
281-
}
282282
}

src/Report/Html/Renderer/Directory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function render(DirectoryNode $node, string $file): void
4848
$template->renderTo($file);
4949
}
5050

51-
protected function renderItem(Node $node, bool $total = false): string
51+
private function renderItem(Node $node, bool $total = false): string
5252
{
5353
$data = [
5454
'numClasses' => $node->numberOfClassesAndTraits(),

src/Report/Html/Renderer/File.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public function render(FileNode $node, string $file): void
4343
$template->renderTo($file);
4444
}
4545

46-
protected function renderItems(FileNode $node): string
46+
private function renderItems(FileNode $node): string
4747
{
4848
$templateName = $this->templatePath . ($this->hasBranchCoverage ? 'file_item_branch.html' : 'file_item.html');
4949
$template = new Template($templateName, '{{', '}}');
@@ -103,7 +103,7 @@ protected function renderItems(FileNode $node): string
103103
return $items;
104104
}
105105

106-
protected function renderTraitOrClassItems(array $items, Template $template, Template $methodItemTemplate): string
106+
private function renderTraitOrClassItems(array $items, Template $template, Template $methodItemTemplate): string
107107
{
108108
$buffer = '';
109109

@@ -207,7 +207,7 @@ protected function renderTraitOrClassItems(array $items, Template $template, Tem
207207
return $buffer;
208208
}
209209

210-
protected function renderFunctionItems(array $functions, Template $template): string
210+
private function renderFunctionItems(array $functions, Template $template): string
211211
{
212212
if (empty($functions)) {
213213
return '';
@@ -225,7 +225,7 @@ protected function renderFunctionItems(array $functions, Template $template): st
225225
return $buffer;
226226
}
227227

228-
protected function renderFunctionOrMethodItem(Template $template, array $item, string $indent = ''): string
228+
private function renderFunctionOrMethodItem(Template $template, array $item, string $indent = ''): string
229229
{
230230
$numMethods = 0;
231231
$numTestedMethods = 0;
@@ -289,7 +289,7 @@ protected function renderFunctionOrMethodItem(Template $template, array $item, s
289289
);
290290
}
291291

292-
protected function renderSource(FileNode $node): string
292+
private function renderSource(FileNode $node): string
293293
{
294294
$coverageData = $node->lineCoverageData();
295295
$testData = $node->testData();
@@ -408,7 +408,7 @@ protected function renderSource(FileNode $node): string
408408
/**
409409
* @param string $file
410410
*/
411-
protected function loadFile($file): array
411+
private function loadFile($file): array
412412
{
413413
$buffer = \file_get_contents($file);
414414
$tokens = \token_get_all($buffer);

0 commit comments

Comments
 (0)