check for updates #1764

nornagon-openai · 2025-07-31T19:34:01Z

Ping https://api.github.com/repos/openai/codex/releases/latest (at most once every 20 hrs)
Store the result in ~/.codex/version.jsonl
If CARGO_PKG_VERSION < latest_version, print a message at boot.

bolinfest · 2025-07-31T22:39:55Z

codex-rs/tui/src/lib.rs

+        let update_command = if cfg!(target_os = "macos")
+            && (exe.starts_with("/opt/homebrew") || exe.starts_with("/usr/local"))
+        {
+            "brew upgrade codex"
+        } else {
+            "npm install -g @openai/codex@latest"
+        };


To recommend npm install, I think we should add the check in here:

https://github.com/openai/codex/blob/main/codex-cli/bin/codex.js

I think we should have a special build-time env var when building for Homebrew:

https://github.com/bolinfest/homebrew-core/blob/main/Formula/c/codex.rb

And check it with env!() and set the update_command, as appropriate.

If there is no valid update_command, we should point the user to https://github.com/openai/codex/releases/latest (maybe even the artifact within latest, though we have to commit to the artifact names to future-proof it)

i feel it's a bummer to have to build O(N*M) binaries for N distribution channels on M platforms. granted brew is only on one platform, but apt-get x snap x pacman x ...

it would be good if this were an install-time configuration. when the package manager installs the package, it writes out a system-wide config (/etc/codex/config.toml?) that contains the command to upgrade.

I generally agree that seems better, though I've been trying to think through that could be abused by a bad actor in some way.

i think if as a bad actor you can edit files in /etc, you have already won. /etc/hosts for instance, or /etc/zshrc.

Sure, though neither npm install -g nor brew install should be run as root, so they can't write /etc either?

easong-openai · 2025-08-01T20:04:37Z

I think we need some notification for users that they're out of date ASAP - how about passing in some signal from the node script to let the rust app know it's managed by NPM, then we can detect that and display an npm message, followed by a homebrew message if we're on macos and then a generic message otherwise?

bolinfest · 2025-08-01T22:20:41Z

codex-rs/tui/src/updates.rs

+    Ok(serde_json::from_str(&contents)?)
+}
+
+async fn update_version(version_file: &Path) -> anyhow::Result<()> {


Can you add a docstring and/or rename? This doesn't update the version of the CLI, but the version file with metadata, is that right?

bolinfest · 2025-08-01T22:21:50Z

codex-rs/tui/src/updates.rs

+    Ok(())
+}
+
+fn is_newer(latest: &str, current: &str) -> Option<bool> {


Can you please add some unit tests so we can be sure that something like 0.11.0-beta.1 always fails the is_newer() check? I believe that is the case right now, but I want to be sure we don't regress that.

bolinfest · 2025-08-01T22:22:45Z

codex-rs/tui/src/lib.rs

+        let current_version = env!("CARGO_PKG_VERSION");
+        let exe = std::env::current_exe()?;
+        let update_command = if cfg!(target_os = "macos")
+            && (exe.starts_with("/opt/homebrew") || exe.starts_with("/usr/local"))


Why don't we drop exe.starts_with("/usr/local")) for now? There's a lot of ways one can end up with /usr/local/bin/codex and I'm not sure how often I believe it is brew install.

If someone didn't install it through the recommended installation paths I think okay if they have to figure out how to update?

bolinfest · 2025-08-01T22:23:30Z

codex-rs/tui/src/updates.rs

+        None => true,
+        Some(info) => info.last_checked_at < Utc::now() - Duration::hours(20),
+    } {
+        tokio::spawn(async move {


So we spawn this, but nothing waits for it? I'm a bit confused what the expectation here is.

Seems okayish - check for update on startup, then you get a banner the next time you open it. That way we don't wait for the network call in order to start.

bolinfest

All small stuff: thanks for doing this!

bolinfest · 2025-08-01T23:24:38Z

codex-rs/tui/Cargo.toml

@@ -42,6 +42,9 @@ ratatui = { version = "0.29.0", features = [
 ratatui-image = "8.0.0"
 regex-lite = "0.1"
 serde_json = { version = "1", features = ["preserve_order"] }
+serde = { version = "1", features = ["derive"] }


alpha-sort?

bolinfest · 2025-08-01T23:26:34Z

codex-rs/tui/src/lib.rs

@@ -139,6 +144,38 @@ pub async fn run_main(
        .with(tui_layer)
        .try_init();

+    #[allow(clippy::print_stderr)]


Low pri, but I would consider moving this to updates.rs so you can have a smaller thing attached to #[cfg(not(debug_assertions))].

bolinfest · 2025-08-01T23:28:32Z

codex-rs/tui/src/updates.rs

+    })
+}
+
+#[derive(serde::Serialize, serde::Deserialize, Debug, Clone)]


I use use serde::Deserialize and Deserialize at the top, FYI.

bolinfest · 2025-08-01T23:29:04Z

codex-rs/tui/src/updates.rs

+    last_checked_at: chrono::DateTime<chrono::Utc>,
+}
+
+const VERSION_FILENAME: &str = "version.jsonl";


Not just .json?

bolinfest · 2025-08-01T23:30:07Z

codex-rs/tui/src/updates.rs

+    let mut path = config.codex_home.clone();
+    path.push(VERSION_FILENAME);
+    path


It should be possible to do something like this?

Suggested change

let mut path = config.codex_home.clone();

path.push(VERSION_FILENAME);

path

config.codex_home.join(VERSION_FILENAME).to_path_buf()

bolinfest · 2025-08-01T23:30:46Z

codex-rs/tui/src/updates.rs

+}
+
+async fn check_for_update(version_file: &Path) -> anyhow::Result<()> {
+    #[derive(serde::Deserialize, Debug, Clone)]


I would just make this a top level struct, but up to you.

bolinfest · 2025-08-01T23:31:35Z

codex-rs/tui/src/updates.rs

+        latest_version: latest_tag_name
+            .strip_prefix("rust-v")
+            .ok_or_else(|| {
+                anyhow::anyhow!("Failed to parse latest tag name '{}'", latest_tag_name)


Suggested change

anyhow::anyhow!("Failed to parse latest tag name '{}'", latest_tag_name)

anyhow::anyhow!("Failed to parse latest tag name '{latest_tag_name}'")

bolinfest · 2025-08-01T23:32:32Z

codex-rs/tui/src/updates.rs

+
+    let json_line = format!("{}\n", serde_json::to_string(&info)?);
+    if let Some(parent) = version_file.parent() {
+        tokio::fs::create_dir_all(parent).await.ok();


Why ok() instead of ? (and two lines down)

bolinfest · 2025-08-01T23:34:00Z

codex-rs/tui/src/updates.rs

+        tag_name: String,
+    }
+
+    let resp = reqwest::Client::new()


Feels like a good candidate for destructuring:

Suggested change

let resp = reqwest::Client::new()

let ReleaseInfo { tag_name: latest_tag_name} = reqwest::Client::new()

and then you can remove:

let latest_tag_name = resp.tag_name;

check for updates

acd18c7

nornagon-openai requested review from bolinfest and easong-openai July 31, 2025 19:34

nornagon-openai added the codex-rust-review Perform a detailed review of Rust changes. label Jul 31, 2025

github-actions bot added codex-rust-review-in-progress and removed codex-rust-review Perform a detailed review of Rust changes. labels Jul 31, 2025

This comment was marked as resolved.

Sign in to view

github-actions bot added codex-rust-review-completed and removed codex-rust-review-in-progress labels Jul 31, 2025

missing file

8888485

bolinfest reviewed Jul 31, 2025

View reviewed changes

bolinfest requested changes Aug 1, 2025

View reviewed changes

easong-openai added 5 commits August 1, 2025 15:36

proposed changes

d835396

no need to suggest homebrew

50dc992

improvements

0fdafe5

tests

a5b986c

Add managed by npm flag to update check (#1788)

3e9e688

bolinfest approved these changes Aug 1, 2025

View reviewed changes

easong-openai added 2 commits August 1, 2025 17:03

nits

089e0c8

merge

9f0c8b2

easong-openai enabled auto-merge (squash) August 2, 2025 00:22

easong-openai disabled auto-merge August 2, 2025 00:23

easong-openai added 2 commits August 1, 2025 17:25

alpha sort

e014398

Merge branch 'main' into nornagon/check-updates

6e37494

easong-openai enabled auto-merge (squash) August 2, 2025 00:25

easong-openai merged commit 7e0f506 into main Aug 2, 2025
11 checks passed

easong-openai deleted the nornagon/check-updates branch August 2, 2025 00:31

github-actions bot locked and limited conversation to collaborators Aug 2, 2025

	anyhow::anyhow!("Failed to parse latest tag name '{}'", latest_tag_name)
	anyhow::anyhow!("Failed to parse latest tag name '{latest_tag_name}'")

	let resp = reqwest::Client::new()
	let ReleaseInfo { tag_name: latest_tag_name} = reqwest::Client::new()

check for updates #1764

check for updates #1764

Conversation

nornagon-openai commented Jul 31, 2025

Uh oh!

This comment was marked as resolved.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nornagon-openai Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

easong-openai commented Aug 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bolinfest left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nornagon-openai Aug 1, 2025 •

edited

Loading