Skip to content

convert.sync - sync version that does not dereference #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

theoephraim
Copy link

This introduces a new convert.sync method which is a synchronous version equivalent to calling with dereference = false.

In my use case the function being asynchronous introduced a whole chain of async function calls which added unnecessary complexity. This will help.

Thanks!!

@ap-simon
Copy link

Thanks for this one, works on my machine!

@JoshuaWise
Copy link

Any chance this will get merged in soon?

@theoephraim
Copy link
Author

@philsturgeon - can we get this merged please? Thanks!

@philsturgeon
Copy link
Member

My concern here is that it's only a partial implementation. Having a sync() without dereferencing is only useful for those who don't want dereferencing. For those who do, would it not be an unexpected outcome, and would it not block people who are trying to figure out why they've got $ref in there when the docs said it should be resolved?

Either way, can you add documentation of which this method is doing so that people know how it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants