Remove Name::append() and Name::prepend()

Author: nikic

CHANGELOG.md

@@ -30,6 +30,8 @@ This release primarily improves our support for error recovery.
 
 ### Removed
 
+* Removed `Name::append()` and `Name::prepend()`. These mutable methods have been superseded by
+  the immutable `Name::concat()`.
 * Removed `Error::getRawLine()` and `Error::setRawLine()`. These methods have been superseded by
   `Error::getStartLine()` and `Error::setStartLine()`.
 * Removed support for node cloning in the `NodeTraverser`.

UPGRADE-3.0.md

@@ -132,8 +132,8 @@ This means that certain error conditions are no longer checked for manually cons
 The following methods, arguments or options have been removed:
 
  * `Comment::setLine()`, `Comment::setText()`: Create new `Comment` instances instead.
- * `Name::set()`, `Name::setFirst()`, `Name::setLast()`: Create new `Name` instances instead. For
-   the latter two a combination of `Name::concat()` and `Name::slice()` can be used.
+ * `Name::set()`, `Name::setFirst()`, `Name::setLast()`, `Name::append()`, `Name::prepend()`:
+    Use `Name::concat()` in combination with `Name::slice()` instead.
  * `Error::getRawLine()`, `Error::setRawLine()`. Use `Error::getStartLine()` and
    `Error::setStartLine()` instead.
  * `Parser::getErrors()`. Use `ErrorHandler\Collecting` instead.

lib/PhpParser/Node/Name.php

@@ -102,28 +102,6 @@ public function __toString() {
         return implode('\\', $this->parts);
     }
 
-    /**
-     * Prepends a name to this name.
-     *
-     * @deprecated Use Name::concat($name1, $name2) instead
-     *
-     * @param string|array|self $name Name to prepend
-     */
-    public function prepend($name) {
-        $this->parts = array_merge(self::prepareName($name), $this->parts);
-    }
-
-    /**
-     * Appends a name to this name.
-     *
-     * @deprecated Use Name::concat($name1, $name2) instead
-     *
-     * @param string|array|self $name Name to append
-     */
-    public function append($name) {
-        $this->parts = array_merge($this->parts, self::prepareName($name));
-    }
-
     /**
      * Gets a slice of a name (similar to array_slice).
      *

test/PhpParser/Node/NameTest.php

@@ -29,26 +29,6 @@ public function testToString() {
         $this->assertSame('foo\bar', $name->toString());
     }
 
-    public function testAppend() {
-        $name = new Name('foo');
-
-        $name->append('bar');
-        $this->assertSame('foo\bar', $name->toString());
-
-        $name->append('bar\foo');
-        $this->assertSame('foo\bar\bar\foo', $name->toString());
-    }
-
-    public function testPrepend() {
-        $name = new Name('foo');
-
-        $name->prepend('bar');
-        $this->assertSame('bar\foo', $name->toString());
-
-        $name->prepend('foo\bar');
-        $this->assertSame('foo\bar\bar\foo', $name->toString());
-    }
-
     public function testSlice() {
         $name = new Name('foo\bar\baz');
         $this->assertEquals(new Name('foo\bar\baz'), $name->slice(0));
@@ -145,7 +125,6 @@ public function testIs() {
      * @expectedExceptionMessage When changing a name you need to pass either a string, an array or a Name node
      */
     public function testInvalidArg() {
-        $name = new Name('foo');
-        $name->append(new \stdClass);
+        Name::concat('foo', new \stdClass);
     }
 }