Skip to content

Cast max age to integer #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2016
Merged

Cast max age to integer #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bac07f6
Cast max age to integer
GeLoLabs Jul 26, 2016
7a3d1d1
Update CHANGELOG
GeLoLabs Jul 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change Log

## UNRELEASED

### Fixed

- Cast max age header to integer in order to get valid expiration value.

## 1.0.0 - 2016-05-05

Expand Down
2 changes: 1 addition & 1 deletion src/CachePlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ private function getMaxAge(ResponseInterface $response)
return $maxAge - ((int) $age);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will cast to int automatically, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the cast is implicit here.

}

return $maxAge;
return (int) $maxAge;
}

// check for ttl in the Expires header
Expand Down