Skip to content

Rename all remaining bsconfig.json to rescript.json #7697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rewatch/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ pub enum DeprecationWarning {
BscFlags,
}

/// # bsconfig.json representation
/// # rescript.json representation
/// This is tricky, there is a lot of ambiguity. This is probably incomplete.
#[derive(Deserialize, Debug, Clone, Default)]
pub struct Config {
Expand Down Expand Up @@ -256,10 +256,10 @@ pub struct Config {
pub jsx: Option<JsxSpecs>,
#[serde(rename = "gentypeconfig")]
pub gentype_config: Option<GenTypeConfig>,
// this is a new feature of rewatch, and it's not part of the bsconfig.json spec
// this is a new feature of rewatch, and it's not part of the rescript.json spec
#[serde(rename = "namespace-entry")]
pub namespace_entry: Option<String>,
// this is a new feature of rewatch, and it's not part of the bsconfig.json spec
// this is a new feature of rewatch, and it's not part of the rescript.json spec
#[serde(rename = "allowed-dependents")]
pub allowed_dependents: Option<Vec<String>>,

Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions rewatch/tests/suffix.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ else
fi

# Replace suffix
replace "s/.mjs/.res.js/g" bsconfig.json
replace "s/.mjs/.res.js/g" rescript.json

error_output=$(rewatch build 2>&1)
if [ $? -eq 0 ];
Expand Down Expand Up @@ -50,7 +50,7 @@ else
fi

# Restore Suffix
replace "s/.res.js/.mjs/g" bsconfig.json
replace "s/.res.js/.mjs/g" rescript.json

# Restore original build
error_output=$(rewatch build 2>&1)
Expand Down