Skip to content

Show deprecation warnings for local deps only #7724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2025
Merged

Show deprecation warnings for local deps only #7724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
349eaf4
Show deprecation warnings for local deps only
cknitt Jul 26, 2025
5424aa9
CHANGELOG
cknitt Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#### :nail_care: Polish

- Apply heuristic to suggest using JSX fragments where we guess that might be what the user wanted. https://github.com/rescript-lang/rescript/pull/7714
- Show deprecation warnings for `bs-dependencies` etc. for local dependencies only. https://github.com/rescript-lang/rescript/pull/7724

#### :bug: Bug fix

Expand Down
31 changes: 16 additions & 15 deletions rewatch/src/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,21 +465,22 @@ pub fn incremental_build(

fn log_deprecations(build_state: &BuildState) {
build_state.packages.iter().for_each(|(_, package)| {
package
.config
.get_deprecations()
.iter()
.for_each(|deprecation_warning| match deprecation_warning {
config::DeprecationWarning::BsDependencies => {
log_deprecated_config_field(&package.name, "bs-dependencies", "dependencies");
}
config::DeprecationWarning::BsDevDependencies => {
log_deprecated_config_field(&package.name, "bs-dev-dependencies", "dev-dependencies");
}
config::DeprecationWarning::BscFlags => {
log_deprecated_config_field(&package.name, "bsc-flags", "compiler-flags");
}
});
// Only warn for local dependencies, not external packages
if package.is_local_dep {
package.config.get_deprecations().iter().for_each(
|deprecation_warning| match deprecation_warning {
config::DeprecationWarning::BsDependencies => {
log_deprecated_config_field(&package.name, "bs-dependencies", "dependencies");
}
config::DeprecationWarning::BsDevDependencies => {
log_deprecated_config_field(&package.name, "bs-dev-dependencies", "dev-dependencies");
}
config::DeprecationWarning::BscFlags => {
log_deprecated_config_field(&package.name, "bsc-flags", "compiler-flags");
}
},
);
}
});
}

Expand Down