Make target pointer width in target json an integer #144443
Open
+25
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-compiletest
|
This PR modifies cc @jieyouxu These commits modify compiler targets. Some changes occurred in src/tools/compiletest cc @jieyouxu |
Noratrieb
reviewed
Jul 25, 2025
This comment has been minimized.
This comment has been minimized.
|
I'm inclined to say yes, but it would probably be good to get this merged today so it can be in the same nightly as the other breaking change instead of two consecutive nightlies (it would also be fine to do that, but less cool) |
We already did that with #144443... the current state is just inconsistent. But, no strong opinion. |
WaffleLapkin
force-pushed
the
integer-target-pointer-width
branch
from
bb5b5c5 to
283f21b
Compare
|
@Noratrieb what's the other breaking change? #142352 has been merged for over a month.. |
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
integer-target-pointer-width
branch
from
283f21b to
267f0bd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Uh, but then why did Miri CI only start failing today? Something changed in 9748d87...b56aaec. |
WaffleLapkin
force-pushed
the
integer-target-pointer-width
branch
from
b64ab4a to
b2871e5
Compare
|
The breaking change was probably #144218. |
RalfJung
reviewed
Jul 25, 2025
|
It might be that the field of wrong type just got ignored, which is exactly why Nora ported this to serde. |
|
You are right indeed. The code in #142352: if let Some(s) = obj.remove(name).and_then(|b| b.as_u64()) {
base.$key_name = s as $int_ty;
}
|
RalfJung
reviewed
Jul 25, 2025
This comment has been minimized.
This comment has been minimized.
Well if nothing else we found a bunch of bootstrap/compiletest staging bugs. 😿 |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed (CI). Failed jobs:
|
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 4, 2025
For "stage 1" ui-fulldeps, use the stage 1 compiler to query target info Testing ui-fulldeps in "stage 1" actually uses the stage 0 compiler, so that test programs can link against stage 1 rustc crates. Unfortunately, using the stage 0 compiler causes problems when compiletest tries to obtain target information from the compiler, but the output format has changed since the last bootstrap beta bump. We can work around this by also providing compiletest with a stage 1 compiler, and having it use that compiler to query for target information. --- This fixes the stage 1 ui-fulldeps failure seen at rust-lang#144443 (comment).
rust-timer
added a commit
that referenced
this pull request
Aug 4, 2025
Rollup merge of #144848 - Zalathar:ui-fulldeps, r=clubby789 For "stage 1" ui-fulldeps, use the stage 1 compiler to query target info Testing ui-fulldeps in "stage 1" actually uses the stage 0 compiler, so that test programs can link against stage 1 rustc crates. Unfortunately, using the stage 0 compiler causes problems when compiletest tries to obtain target information from the compiler, but the output format has changed since the last bootstrap beta bump. We can work around this by also providing compiletest with a stage 1 compiler, and having it use that compiler to query for target information. --- This fixes the stage 1 ui-fulldeps failure seen at #144443 (comment).
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Aug 4, 2025
For "stage 1" ui-fulldeps, use the stage 1 compiler to query target info Testing ui-fulldeps in "stage 1" actually uses the stage 0 compiler, so that test programs can link against stage 1 rustc crates. Unfortunately, using the stage 0 compiler causes problems when compiletest tries to obtain target information from the compiler, but the output format has changed since the last bootstrap beta bump. We can work around this by also providing compiletest with a stage 1 compiler, and having it use that compiler to query for target information. --- This fixes the stage 1 ui-fulldeps failure seen at rust-lang/rust#144443 (comment).
WaffleLapkin
force-pushed
the
integer-target-pointer-width
branch
from
ffe4f0c to
1a5b2b0
Compare
WaffleLapkin
force-pushed
the
integer-target-pointer-width
branch
from
1a5b2b0 to
c4ca575
Compare
rust-bors bot
added a commit
that referenced
this pull request
Aug 4, 2025
…<try> Make target pointer width in target json an integer try-job: x86_64-gnu-llvm-19-3
|
@bors r=Noratrieb |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 5, 2025
…r-width, r=Noratrieb Make target pointer width in target json an integer r? Noratrieb cc `@RalfJung` (https://github.com/rust-lang/rust/pull/142352/files#r2230380120)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 5, 2025
…r-width, r=Noratrieb Make target pointer width in target json an integer r? Noratrieb cc ``@RalfJung`` (https://github.com/rust-lang/rust/pull/142352/files#r2230380120)
bors
added a commit
that referenced
this pull request
Aug 5, 2025
Rollup of 16 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #144133 (Stabilize const TypeId::of) - #144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - #144443 (Make target pointer width in target json an integer) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144682 (Stabilize `strict_overflow_ops`) - #144794 (Port `#[coroutine]` to the new attribute system) - #144835 (Anonymize binders in tail call sig) - #144836 (Change visibility of Args new function) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144903 (Rename `begin_panic_handler` to `panic_handler`) - #144910 (Add regression tests for seemingly fixed issues) - #144926 (Correct the use of `must_use` on btree::IterMut) - #144928 (Drop `rust-version` from `rustc_thread_pool`) - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC) Failed merges: - #144914 (Add support for `ty::Instance` path shortening in diagnostics) r? `@ghost` `@rustbot` modify labels: rollup
|
Most likely failed in #144942 (comment). @bors r- |
bors
added
S-waiting-on-author
|
Looks like cargo's tests are asserting on the text emitted by EDIT: Given that cfg values must be strings, this seems like an actual unintended breakage that was not caught by rustc tests, but was caught by cargo tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? Noratrieb
cc @RalfJung (https://github.com/rust-lang/rust/pull/142352/files#r2230380120)