Fix [rustdoc] Non-json time diagnostics in stdout when using --format… #144821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the display_times method in doctest.rs to check if JSON output is requested before printing the timing information. Here's what the change does:
Added a check for --format or --format=json in the command-line arguments using std::env::args().any()
The timing information will only be printed if:
There were merged doctests compiled (self.added_compilation_times > 0)
AND JSON format is NOT requested
This change ensures that when running with --format json, the timing information won't be printed to stdout, which would otherwise corrupt the JSON output. The timing information is still available when running in the default format.