Move several more float tests to floats/mod.rs #144923
Draft
+418
−1,192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clobbers the existing generic abs test, but it covers strictly more, so that seems fine.
Note that the behaviour of the f128 test is slightly changed to use the same nan mask as is used in test_float_bits_conv, which is the behaviour used by f16,f32,and f64.
rustbot
added
S-waiting-on-author
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rocurley
force-pushed
the
float_tests_refactor_3
branch
from
4737950 to
4e92c1c
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
This standardizes how max and min subnormals are generated. Since the new method doesn't use powf, it also enables some of the tests for f128 that were previously disabled due to issues with powf (although it looks like those issues were already fixed anyway). f16 signalling nan tests previously disabled are not re-enabled, since the underlying LLVM issue has not been closed.
rocurley
force-pushed
the
float_tests_refactor_3
branch
from
4e92c1c to
4d3f410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves several tests to
floats/mod.rs, as discussed in #141726. The tests moved are:test_abstest_signumtest_is_sign_positivetest_is_sign_negativetest_next_uptest_next_downtest_sqrt_domaintest_clamp_min_greater_than_maxtest_clamp_min_is_nantest_clamp_max_is_nantest_total_cmpThis covers all the "easy" tests: the ones that don't have a lot of precision-specific constants. It's not clear to me that it's worth migrating the others.
Each test is its own commit (with the exception of the clamp tests), so it may be easiest to review each commit individually.
r? tgross35