Link from "Overview of the compiler § Queries" to the Queries chapter #2538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's already a link in the other direction, so this seems fairly logical.
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
tshepang
reviewed
Aug 6, 2025
src/overview.md
Outdated
| @@ -321,6 +321,10 @@ the name `'tcx`, which means that something is tied to the lifetime of the | |||
|
|
|||
| [`TyCtxt`]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/struct.TyCtxt.html | |||
|
|
|||
| For more information about queries in the compiler, see [the queries chapter][queries]. | |||
|
|
|||
| [queries]: https://rustc-dev-guide.rust-lang.org/query.html | |||
There was a problem hiding this comment.
there is some intro text in same page
Suggested change
| [queries]: https://rustc-dev-guide.rust-lang.org/query.html | |
| [queries]: #queries |
There was a problem hiding this comment.
That's... the section I'm linking from? The section linking to itself isn't useful at all, it needs to link to the chapter.
Anyways this did make me realize I should be using relative a relative URL, so that's been updated.
There was a problem hiding this comment.
That's... the section I'm linking from? The section linking to itself isn't useful at all, it needs to link to the chapter.
heh, of course I missed that :)
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's already a link in the other direction, so this seems fairly logical.