debug-assertions=true instead of debug-assertions=yes #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Sep 17, 2020
src/compiler-debugging.md
Outdated
| @@ -207,10 +207,10 @@ $ RUSTDOC_LOG=rustdoc rustdoc +local my-file.rs | |||
|
|
|||
| While calls to `error!`, `warn!` and `info!` are included in every build of the compiler, | |||
| calls to `debug!` and `trace!` are only included in the program if | |||
| `debug-assertions=yes` is turned on in config.toml (it is | |||
| `debug-assertions=true` is turned on in config.toml (it is | |||
There was a problem hiding this comment.
Good catch, thanks! Although this actually changed recently to be more specific: rust-lang/rust#76588
Suggested change
| `debug-assertions=true` is turned on in config.toml (it is | |
| `debug-logging=true` is turned on in config.toml (it is |
src/compiler-debugging.md
Outdated
| turned off by default), so if you don't see `DEBUG` logs, especially | ||
| if you run the compiler with `RUSTC_LOG=rustc rustc some.rs` and only see | ||
| `INFO` logs, make sure that `debug-assertions=yes` is turned on in your | ||
| `INFO` logs, make sure that `debug-assertions=true` is turned on in your |
There was a problem hiding this comment.
Suggested change
| `INFO` logs, make sure that `debug-assertions=true` is turned on in your | |
| `INFO` logs, make sure that `debug-logging=true` is turned on in your |
jyn514
added
the
S-waiting-on-author
macdonaldo
force-pushed
the
debug-assertions
branch
from
07fb6f9 to
232d1fe
Compare
jyn514
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.