Guard against processor re-entry

Changing filenames in the return value of `preprocess()` automatically triggers the processor again for those "new files". This adds a guard to bail in processing if those temporary files come in for new processing.

Author: khawkins

lib/processor.js

@@ -8,8 +8,13 @@
 'use strict';
 
 const { extname } = require('path');
-const { setLwcBundleCacheEntry, removeLwcBundleCacheEntry } = require('./util/helper');
+const {
+    setLwcBundleCacheEntry,
+    removeLwcBundleCacheEntry,
+    extractBundleKey
+} = require('./util/helper');
 const LwcBundle = require('./lwc-bundle');
+const bundleStateManager = require('./util/bundle-state-manager');
 
 const SUPPORTS_AUTOFIX = true;
 
@@ -83,6 +88,13 @@ class BundleAnalyzer {
      * @returns {{ text: string, filename: string }[]} An array of files and their content, to be processed.
      */
     preprocess = (text, filename) => {
+        // Check if this is a file we generated ourselves with `preprocess()` return values.
+        const bundleKey = extractBundleKey(filename);
+        if (bundleStateManager.hasBundleWithKey(bundleKey)) {
+            // Skip processing for files we generated
+            return [{ text, filename }];
+        }
+
         const fileExtension = extname(filename);
 
         // If this.#lwcBundle has already been set, use that data. Otherwise, create

lib/util/bundle-state-manager.js

@@ -65,6 +65,16 @@ class BundleStateManager {
     clear() {
         this.#bundleMap.clear();
     }
+
+    /**
+     * Checks if a bundle exists with the given key
+     *
+     * @param {string} key - The unique key to check for
+     * @returns {boolean} True if a bundle exists with the given key, false otherwise
+     */
+    hasBundleWithKey(key) {
+        return this.#bundleMap.has(key);
+    }
 }
 
 // Export a singleton instance

lib/util/helper.js

@@ -142,5 +142,6 @@ function getKomaciReport(ruleName, filename) {
 module.exports = {
     setLwcBundleCacheEntry,
     removeLwcBundleCacheEntry,
-    analyzeLWC
+    analyzeLWC,
+    extractBundleKey
 };

test/lib/processor.js

@@ -10,6 +10,7 @@
 const { expect } = require('chai');
 const bundleAnalyzer = require('../../lib/processor');
 const LwcBundle = require('../../lib/lwc-bundle');
+const bundleStateManager = require('../../lib/util/bundle-state-manager');
 
 describe('BundleAnalyzer', () => {
     beforeEach(() => {
@@ -96,6 +97,36 @@ describe('BundleAnalyzer', () => {
             expect(bundleAnalyzer.lwcBundle.primaryFile).to.equal(bundleAnalyzer.lwcBundle.js);
             expect(result[0].filename).to.equal(bundleAnalyzer.lwcBundle.getBundleKey());
         });
+
+        it('should skip processing for files that have already been processed', () => {
+            // First create a bundle and add it to the state manager
+            const jsContent = 'export default class Test {}';
+            const bundle = LwcBundle.lwcBundleFromContent('test', jsContent);
+            // Set the primary file before getting the bundle key
+            bundle.setPrimaryFileByContent(jsContent);
+            const bundleKey = bundle.getBundleKey();
+            bundleStateManager.addBundleState(bundle);
+
+            // Now try to process a file with the same bundle key
+            const result = bundleAnalyzer.preprocess(jsContent, `/some/path/0_${bundleKey}`);
+
+            // Should return the original text without further processing
+            expect(result).to.have.length(1);
+            expect(result[0].text).to.equal(jsContent);
+            expect(result[0].filename).to.equal(`/some/path/0_${bundleKey}`);
+
+            // Clean up
+            bundleStateManager.removeBundleState(bundle);
+        });
+
+        it('should process files that have not been processed before', () => {
+            const jsContent = 'export default class Test {}';
+            const result = bundleAnalyzer.preprocess(jsContent, 'test.js');
+
+            expect(result).to.have.length(1);
+            expect(result[0].text).to.equal(jsContent);
+            expect(bundleAnalyzer.lwcBundle).to.be.instanceof(LwcBundle);
+        });
     });
 
     describe('postprocess', () => {