fix nested array analysis

Author: mvorisek

src/StaticAnalysis/ExecutableLinesFindingVisitor.php

@@ -250,7 +250,7 @@ private function getLines(NodeAbstract $node, bool $fromReturns): array
         }
 
         if ($node instanceof Case_) {
-            if (null === $node->cond) {
+            if (null === $node->cond) { // default case
                 return [];
             }
 
@@ -290,7 +290,7 @@ private function getNodeStartLine(NodeAbstract $node): int
                 return $node->getEndLine();
             }
 
-            return $this->getNodeStartLine($node->items[0]);
+            return $this->getNodeStartLine($node->items[0]->value);
         }
 
         if ($node instanceof Assign) {

tests/_files/source_with_multiline_constant_return.php

@@ -509,4 +509,60 @@ public function emptyMethodWithComment(): void
     {
         // empty method with comment
     }
+
+    public function simpleConstArrayEmpty(): array
+    {
+        return
+        [
+            // empty array with comment
+        ];
+    }
+
+    public function nestedConstArrayEmpty(): array
+    {
+        return
+        [
+            [
+                // empty subarray with comment
+            ]
+        ];
+    }
+
+    public function nestedConstArrayOne(): array
+    {
+        return
+        [
+            [
+                <<<'EOF'
+                    1
+                    EOF,
+            ]
+        ];
+    }
+
+    public function nestedConstArrayTwo(): array
+    {
+        return
+        [
+            [
+                <<<'EOF'
+                    1
+                    EOF,
+                2,
+            ]
+        ];
+    }
+
+    public function nestedArrayWithExecutableInKey(): array
+    {
+        return
+        [
+            [
+                1,
+                phpversion()
+                    =>
+                        2,
+            ]
+        ];
+    }
 }

tests/tests/Data/RawCodeCoverageDataTest.php

@@ -533,6 +533,11 @@ public function testReturnStatementWithConstantExprOnlyReturnTheLineOfLast(): vo
                 492,
                 506,
                 511,
+                518,
+                527,
+                537,
+                549,
+                562,
             ],
             array_keys(RawCodeCoverageData::fromUncoveredFile($file, new ParsingFileAnalyser(true, true))->lineCoverage()[$file])
         );