Skip to content

Commit cf8048a

Browse files
committed
No need to set PYENV_VERSION for system.
Since each command runs in a new shell, and the path looks for system Python *first*, setting PYENV_VERSION here doesn’t even do anything. It was looking at the system Python 2.7 because that’s the default `python` bin.
1 parent 8bba7d3 commit cf8048a

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

circle.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,11 @@ dependencies:
1111
# run all the pre-written installers (this will take a *while*)
1212
- bash circle/setup.sh
1313
# install testing tools for circle's version of things
14-
- PYENV_VERSION=2.7 && pip install nose coverage
14+
- pip install nose coverage
1515
override:
16-
- PYENV_VERSION=2.7 && pip install -I .
17-
- PYENV_VERSION=2.7 && cd ~ && python -c "import plotly"
16+
- pip install -I .
17+
# we need to cd out of the project root to ensure the install worked
18+
- cd ~ && python -c "import plotly"
1819
test:
1920
override:
2021

@@ -28,6 +29,6 @@ test:
2829
# - sudo chmod 600 ${PLOTLY_CONFIG_DIR} && python -c "import plotly"
2930

3031
# test core things in the general 2.7 version that circle has
31-
- PYENV_VERSION=2.7 && nosetests -xv plotly/tests --with-coverage --cover-package=plotly
32+
- nosetests -xv plotly/tests --with-coverage --cover-package=plotly
3233
- mkdir "${CIRCLE_ARTIFACTS}/2.7" || true
3334
- coverage html -d "${CIRCLE_ARTIFACTS}/2.7" --title=2.7

0 commit comments

Comments
 (0)