Skip to content

Commit c88e6db

Browse files
committed
chore: add todos
1 parent 7098518 commit c88e6db

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

src/router.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,7 @@ export function createRouter(options: RouterOptions): Router {
522522
function locationAsObject(
523523
to: RouteLocationRaw | RouteLocationNormalized
524524
): Exclude<RouteLocationRaw, string> | RouteLocationNormalized {
525+
// FIXME: does not take into account query params
525526
return typeof to === 'string' ? { path: to } : assign({}, to)
526527
}
527528

@@ -586,7 +587,9 @@ export function createRouter(options: RouterOptions): Router {
586587
}
587588

588589
function pushWithRedirect(
590+
// TODO: should only be RouteLocation?
589591
to: RouteLocationRaw | RouteLocation,
592+
// TODO: add replace here
590593
redirectedFrom?: RouteLocation
591594
): Promise<NavigationFailure | void | undefined> {
592595
const targetLocation: RouteLocation = (pendingLocation = resolve(to))

src/types/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export type RouteParamsRaw = Record<
2727
RouteParamValueRaw | RouteParamValueRaw[]
2828
>
2929

30+
// TODO: document, mark as internal and export intermediate types for RouteLocationRaw
3031
export interface RouteQueryAndHash {
3132
query?: LocationQueryRaw
3233
hash?: string

0 commit comments

Comments
 (0)