refactor(core): Replace "var" (vuejs#8299)

Replaces instances of "var" with "let" and "const" where applicable using the eslint 'no-var' and
'prefer-const' rules

Author: slichlyter12

scripts/build.js

@@ -48,7 +48,7 @@ function buildEntry (config) {
     .then(bundle => bundle.generate(output))
     .then(({ code }) => {
       if (isProd) {
-        var minified = (banner ? banner + '\n' : '') + terser.minify(code, {
+        const minified = (banner ? banner + '\n' : '') + terser.minify(code, {
           output: {
             ascii_only: true
           },

scripts/get-weex-version.js

@@ -1,7 +1,7 @@
-var coreVersion = require('../package.json').version
-var weexVersion = require('../packages/weex-vue-framework/package.json').version
-var weexBaseVersion = weexVersion.match(/^[\d.]+/)[0]
-var weexSubVersion = Number(weexVersion.match(/-weex\.(\d+)$/)[1])
+const coreVersion = require('../package.json').version
+const weexVersion = require('../packages/weex-vue-framework/package.json').version
+let weexBaseVersion = weexVersion.match(/^[\d.]+/)[0]
+let weexSubVersion = Number(weexVersion.match(/-weex\.(\d+)$/)[1])
 
 if (weexBaseVersion === coreVersion) {
   // same core version, increment sub version

src/platforms/web/runtime/components/transition-group.js

@@ -111,8 +111,8 @@ export default {
 
     children.forEach((c: VNode) => {
       if (c.data.moved) {
-        var el: any = c.elm
-        var s: any = el.style
+        const el: any = c.elm
+        const s: any = el.style
         addTransitionClass(el, moveClass)
         s.transform = s.WebkitTransform = s.transitionDuration = ''
         el.addEventListener(transitionEndEvent, el._moveCb = function cb (e) {

src/platforms/web/util/style.js

@@ -8,7 +8,7 @@ export const parseStyleText = cached(function (cssText) {
   const propertyDelimiter = /:(.+)/
   cssText.split(listDelimiter).forEach(function (item) {
     if (item) {
-      var tmp = item.split(propertyDelimiter)
+      const tmp = item.split(propertyDelimiter)
       tmp.length > 1 && (res[tmp[0].trim()] = tmp[1].trim())
     }
   })

src/platforms/weex/runtime/modules/style.js

@@ -70,7 +70,7 @@ function updateStyle (oldVnode: VNodeWithData, vnode: VNodeWithData) {
 
 function toObject (arr) {
   const res = {}
-  for (var i = 0; i < arr.length; i++) {
+  for (let i = 0; i < arr.length; i++) {
     if (arr[i]) {
       extend(res, arr[i])
     }

test/e2e/runner.js

@@ -1,25 +1,25 @@
-var path = require('path')
-var spawn = require('cross-spawn')
-var httpServer = require('http-server')
-var server = httpServer.createServer({
+const path = require('path')
+const spawn = require('cross-spawn')
+const httpServer = require('http-server')
+const server = httpServer.createServer({
   root: path.resolve(__dirname, '../../')
 })
 
 server.listen(8080)
 
-var args = process.argv.slice(2)
+let args = process.argv.slice(2)
 if (args.indexOf('--config') === -1) {
   args = args.concat(['--config', 'test/e2e/nightwatch.config.js'])
 }
 if (args.indexOf('--env') === -1) {
   args = args.concat(['--env', 'chrome,phantomjs'])
 }
-var i = args.indexOf('--test')
+const i = args.indexOf('--test')
 if (i > -1) {
   args[i + 1] = 'test/e2e/specs/' + args[i + 1] + '.js'
 }
 
-var runner = spawn('./node_modules/.bin/nightwatch', args, {
+const runner = spawn('./node_modules/.bin/nightwatch', args, {
   stdio: 'inherit'
 })
 

test/e2e/specs/grid.js

@@ -1,6 +1,6 @@
 module.exports = {
   'grid': function (browser) {
-    var columns = ['name', 'power']
+    const columns = ['name', 'power']
 
     browser
     .url('http://localhost:8080/examples/grid/')
@@ -92,8 +92,8 @@ module.exports = {
 
     function assertTable (data) {
       browser.assert.count('td', data.length * columns.length)
-      for (var i = 0; i < data.length; i++) {
-        for (var j = 0; j < columns.length; j++) {
+      for (let i = 0; i < data.length; i++) {
+        for (let j = 0; j < columns.length; j++) {
           browser.assert.containsText(
             'tr:nth-child(' + (i + 1) + ') td:nth-child(' + (j + 1) + ')',
             data[i][columns[j]]

test/e2e/specs/svg.js

@@ -12,8 +12,8 @@ module.exports = {
       .assert.count('button', 7)
       .assert.count('input[type="range"]', 6)
       .assert.evaluate(function () {
-        var points = stats.map(function (stat, i) {
-        var point = valueToPoint(stat.value, i, 6)
+        const points = stats.map(function (stat, i) {
+        const point = valueToPoint(stat.value, i, 6)
           return point.x + ',' + point.y
         }).join(' ')
         return document.querySelector('polygon').attributes[0].value === points
@@ -24,8 +24,8 @@ module.exports = {
       .assert.count('button', 6)
       .assert.count('input[type="range"]', 5)
       .assert.evaluate(function () {
-        var points = stats.map(function (stat, i) {
-        var point = valueToPoint(stat.value, i, 5)
+        const points = stats.map(function (stat, i) {
+        const point = valueToPoint(stat.value, i, 5)
           return point.x + ',' + point.y
         }).join(' ')
         return document.querySelector('polygon').attributes[0].value === points
@@ -37,8 +37,8 @@ module.exports = {
       .assert.count('button', 7)
       .assert.count('input[type="range"]', 6)
       .assert.evaluate(function () {
-        var points = stats.map(function (stat, i) {
-        var point = valueToPoint(stat.value, i, 6)
+        const points = stats.map(function (stat, i) {
+        const point = valueToPoint(stat.value, i, 6)
           return point.x + ',' + point.y
         }).join(' ')
         return document.querySelector('polygon').attributes[0].value === points

test/e2e/specs/tree.js

@@ -63,8 +63,8 @@ module.exports = {
       .assert.count('.item > ul', 5)
       .assert.containsText('#demo ul > .item:nth-child(1)', '[-]')
       .assert.evaluate(function () {
-        var firstItem = document.querySelector('#demo ul > .item:nth-child(1)')
-        var ul = firstItem.querySelector('ul')
+        const firstItem = document.querySelector('#demo ul > .item:nth-child(1)')
+        const ul = firstItem.querySelector('ul')
         return ul.children.length === 2
       })
       .end()

test/helpers/to-have-been-warned.js

@@ -14,8 +14,8 @@ let asserted
 
 function createCompareFn (spy) {
   const hasWarned = msg => {
-    var count = spy.calls.count()
-    var args
+    let count = spy.calls.count()
+    let args
     while (count--) {
       args = spy.calls.argsFor(count)
       if (args.some(containsMsg)) {
@@ -31,7 +31,7 @@ function createCompareFn (spy) {
   return {
     compare: msg => {
       asserted = asserted.concat(msg)
-      var warned = Array.isArray(msg)
+      const warned = Array.isArray(msg)
         ? msg.some(hasWarned)
         : hasWarned(msg)
       return {