Merge pull request webpack#7038 from marcusdarmstrong/marcusdarmstrong-external-module-fix

Correct ExternalModule's global option (webpack#6933)

Author: sokra

lib/ExternalModule.js

@@ -127,8 +127,8 @@ class ExternalModule extends Module {
 				);
 			case "global":
 				return this.getSourceForGlobalVariableExternal(
-					runtime.outputOptions.globalObject,
-					this.externalType
+					request,
+					runtime.outputOptions.globalObject
 				);
 			case "commonjs":
 			case "commonjs2":

test/configCases/externals/global/index.js

@@ -0,0 +1,11 @@
+afterEach(done => {
+	delete global.EXTERNAL_TEST_GLOBAL;
+	done();
+});
+
+it("should move externals in chunks into entry chunk", function() {
+	global.EXTERNAL_TEST_GLOBAL = 42;
+	// eslint-disable-next-line node/no-missing-require
+	const result = require("external");
+	expect(result).toBe(42);
+});

test/configCases/externals/global/webpack.config.js

@@ -0,0 +1,5 @@
+module.exports = {
+	externals: {
+		external: "global EXTERNAL_TEST_GLOBAL"
+	}
+};