misc(kernel): cleanup

Signed-off-by: Anhad Singh <[email protected]>

Author: Andy-Python-Programmer

src/aero_kernel/src/fs/block/gpt.rs

@@ -21,7 +21,6 @@ use super::BlockDevice;
 use core::mem::MaybeUninit;
 
 use alloc::boxed::Box;
-use alloc::sync::Arc;
 
 const GPT_TABLE_SIGNATURE: u64 = 0x5452_4150_2049_4645;
 
@@ -121,7 +120,7 @@ pub struct Gpt {
 }
 
 impl Gpt {
-    pub fn new(controller: Arc<BlockDevice>) -> Option<Self> {
+    pub fn new(controller: &BlockDevice) -> Option<Self> {
         // Get the GPT header.
         let mut header = Box::<GptTableHeader>::new_uninit();
 

src/aero_kernel/src/fs/block/mod.rs

@@ -398,7 +398,7 @@ pub fn launch() -> Result<()> {
     }
 
     for block in blocks_copy {
-        if let Some(gpt) = Gpt::new(block.clone()) {
+        if let Some(gpt) = Gpt::new(&block) {
             log::info!("block: found GPT on {}!", block.name());
 
             for (i, entry) in gpt

src/aero_kernel/src/net/mod.rs

@@ -153,7 +153,7 @@ fn packet_processor_thread() {
                         let options = parser.next::<TcpOptions>();
                         let payload = &parser.payload()[..size];
 
-                        tcp::on_packet(tcp, options, payload)
+                        tcp::on_packet(tcp, &options, payload)
                     }
                 }
             }

src/aero_kernel/src/net/tcp.rs

@@ -25,7 +25,7 @@ use crate::socket::tcp::TcpSocket;
 
 static HANDLERS: RwLock<BTreeMap<u16, Arc<TcpSocket>>> = RwLock::new(BTreeMap::new());
 
-pub fn on_packet(tcp: &Tcp, options: TcpOptions, payload: &[u8]) {
+pub fn on_packet(tcp: &Tcp, options: &TcpOptions, payload: &[u8]) {
     let handlers = HANDLERS.read();
 
     if let Some(handler) = handlers.get(&tcp.dest_port()) {

src/aero_kernel/src/socket/tcp.rs

@@ -75,7 +75,7 @@ impl TcpSocket {
         })
     }
 
-    pub fn on_packet(&self, tcp: &Tcp, options: TcpOptions, payload: &[u8]) {
+    pub fn on_packet(&self, tcp: &Tcp, options: &TcpOptions, payload: &[u8]) {
         if let Some(socket) = self.tcp.lock_irq().as_mut() {
             // Ignore any invalid TCP options.
             let options = options.iter().filter_map(Result::ok).collect::<Vec<_>>();

src/aero_kernel/src/socket/unix.rs

@@ -209,7 +209,7 @@ impl UnixSocket {
         })
     }
 
-    pub fn connect_pair(a: DirCacheItem, b: DirCacheItem) -> fs::Result<()> {
+    pub fn connect_pair(a: &DirCacheItem, b: &DirCacheItem) -> fs::Result<()> {
         let a = a
             .inode()
             .downcast_arc::<UnixSocket>()

src/aero_kernel/src/syscall/net.rs

@@ -337,7 +337,7 @@ pub fn socket_pair(
     let a = create_socket(___domain, type_and_flags, protocol)?;
     let b = create_socket(___domain, type_and_flags, protocol)?;
 
-    UnixSocket::connect_pair(a.clone(), b.clone())?;
+    UnixSocket::connect_pair(&a, &b)?;
 
     fds[0] = current_task.file_table.open_file(a, sockfd_flags)? as i32;
     fds[1] = current_task.file_table.open_file(b, sockfd_flags)? as i32;