Apply changes to v3 parser too, fix formatting, reject with error results (not successes)

Author: CodeLenny

src/openApi/v3/parser/getOperation.ts

@@ -9,7 +9,7 @@ import { getOperationParameters } from './getOperationParameters';
 import { getOperationRequestBody } from './getOperationRequestBody';
 import { getOperationResponseHeader } from './getOperationResponseHeader';
 import { getOperationResponses } from './getOperationResponses';
-import { getOperationResults } from './getOperationResults';
+import { getOperationErrorResults, getOperationResults } from './getOperationResults';
 import { getRef } from './getRef';
 import { getServiceName } from './getServiceName';
 import { sortByRequired } from './sortByRequired';
@@ -73,13 +73,19 @@ export const getOperation = (
     if (op.responses) {
         const operationResponses = getOperationResponses(openApi, op.responses);
         const operationResults = getOperationResults(operationResponses);
+        const operationErrorResults = getOperationErrorResults(operationResponses);
         operation.errors = getOperationErrors(operationResponses);
         operation.responseHeader = getOperationResponseHeader(operationResults);
 
         operationResults.forEach(operationResult => {
             operation.results.push(operationResult);
             operation.imports.push(...operationResult.imports);
         });
+
+        operationErrorResults.forEach(operationResult => {
+            operation.errorResults.push(operationResult);
+            operation.imports.push(...operationResult.imports);
+        });
     }
 
     operation.parameters = operation.parameters.sort(sortByRequired);

src/openApi/v3/parser/getOperationResults.ts

@@ -9,6 +9,41 @@ const areEqual = (a: Model, b: Model): boolean => {
     return equal;
 };
 
+export const getOperationErrorResults = (operationResponses: OperationResponse[]): OperationResponse[] => {
+    const operationResults: OperationResponse[] = [];
+
+    operationResponses.forEach(operationResponse => {
+        const { code } = operationResponse;
+        if (code && (code === 204 || code < 200 || code >= 300)) {
+            operationResults.push(operationResponse);
+        }
+    });
+
+    if (!operationResults.length) {
+        operationResults.push({
+            in: 'response',
+            name: '',
+            code: 0,
+            description: '',
+            export: 'generic',
+            type: 'any',
+            base: 'any',
+            template: null,
+            link: null,
+            isDefinition: false,
+            isReadOnly: false,
+            isRequired: false,
+            isNullable: false,
+            imports: [],
+            enum: [],
+            enums: [],
+            properties: [],
+        });
+    }
+
+    return operationResults;
+};
+
 export const getOperationResults = (operationResponses: OperationResponse[]): OperationResponse[] => {
     const operationResults: OperationResponse[] = [];
 

src/templates/partials/errorResult.hbs

@@ -1,8 +1,5 @@
 {{~#if errorResults~}}
-{{#each results}}ApiError<
-	{{#equals code 0}}number{{else}}{{{code}}}{{/equals}},
-	{{type}}
->{{#unless @last}} | {{/unless}}{{/each}}
+{{#each errorResults}}ApiError<{{#equals code 0}}number{{else}}{{{code}}}{{/equals}}, {{type}}>{{#unless @last}} | {{/unless}}{{/each}}
 {{~else~}}
 ApiError<number, any>
 {{~/if~}}