Skip to content

Commit c849938

Browse files
committed
Fix schema responses not matching tests
1 parent 4b39ef0 commit c849938

File tree

14 files changed

+28
-13
lines changed

14 files changed

+28
-13
lines changed

backend/internal/api/router.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414
"npm/internal/entity/dnsprovider"
1515
"npm/internal/entity/host"
1616
"npm/internal/entity/nginxtemplate"
17+
"npm/internal/entity/setting"
1718
"npm/internal/entity/stream"
1819
"npm/internal/entity/upstream"
1920
"npm/internal/entity/user"
@@ -133,8 +134,11 @@ func applyRoutes(r chi.Router) chi.Router {
133134

134135
// Settings
135136
r.With(middleware.EnforceSetup(true), middleware.Enforce(user.CapabilitySettingsManage)).Route("/settings", func(r chi.Router) {
136-
// r.With(middleware.Filters(setting.GetFilterSchema())).
137-
r.Get("/", handler.GetSettings())
137+
// List
138+
r.With(
139+
middleware.Filters(setting.Model{}),
140+
).Get("/", handler.GetSettings())
141+
138142
r.Get("/{name}", handler.GetSetting())
139143
r.With(middleware.EnforceRequestSchema(schema.CreateSetting())).
140144
Post("/", handler.CreateSetting())

backend/internal/entity/accesslist/methods.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func List(pageInfo model.PageInfo, filters []model.Filter) (entity.ListResponse,
4040
Total: totalRows,
4141
Limit: pageInfo.Limit,
4242
Offset: pageInfo.Offset,
43-
Sort: pageInfo.Sort,
43+
Sort: pageInfo.GetSort(defaultSort),
4444
Filter: filters,
4545
}
4646

backend/internal/entity/certificate/methods.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func List(pageInfo model.PageInfo, filters []model.Filter, expand []string) (ent
6565
Total: totalRows,
6666
Limit: pageInfo.Limit,
6767
Offset: pageInfo.Offset,
68-
Sort: pageInfo.Sort,
68+
Sort: pageInfo.GetSort(defaultSort),
6969
Filter: filters,
7070
}
7171

backend/internal/entity/certificateauthority/methods.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func List(pageInfo model.PageInfo, filters []model.Filter) (entity.ListResponse,
4040
Total: totalRows,
4141
Limit: pageInfo.Limit,
4242
Offset: pageInfo.Offset,
43-
Sort: pageInfo.Sort,
43+
Sort: pageInfo.GetSort(defaultSort),
4444
Filter: filters,
4545
}
4646

backend/internal/entity/dnsprovider/methods.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func List(pageInfo model.PageInfo, filters []model.Filter) (entity.ListResponse,
4040
Total: totalRows,
4141
Limit: pageInfo.Limit,
4242
Offset: pageInfo.Offset,
43-
Sort: pageInfo.Sort,
43+
Sort: pageInfo.GetSort(defaultSort),
4444
Filter: filters,
4545
}
4646

backend/internal/entity/host/methods.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func List(pageInfo model.PageInfo, filters []model.Filter, expand []string) (ent
5151
Total: totalRows,
5252
Limit: pageInfo.Limit,
5353
Offset: pageInfo.Offset,
54-
Sort: pageInfo.Sort,
54+
Sort: pageInfo.GetSort(defaultSort),
5555
Filter: filters,
5656
}
5757

backend/internal/entity/nginxtemplate/methods.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func List(pageInfo model.PageInfo, filters []model.Filter) (entity.ListResponse,
4040
Total: totalRows,
4141
Limit: pageInfo.Limit,
4242
Offset: pageInfo.Offset,
43-
Sort: pageInfo.Sort,
43+
Sort: pageInfo.GetSort(defaultSort),
4444
Filter: filters,
4545
}
4646

backend/internal/entity/scopes.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"fmt"
55
"strings"
66

7+
"npm/internal/logger"
78
"npm/internal/model"
89

910
"gorm.io/gorm"
@@ -36,6 +37,8 @@ func ScopeOrderBy(pageInfo *model.PageInfo, defaultSort model.Sort) func(db *gor
3637
}
3738

3839
func ScopeFilters(filters []model.Filter, filterMap map[string]filterMapValue) func(db *gorm.DB) *gorm.DB {
40+
logger.Debug("FILTERS: %+v", filters)
41+
logger.Debug("FILTERMAP: %+v", filterMap)
3942
return func(db *gorm.DB) *gorm.DB {
4043
for _, f := range filters {
4144
// Lookup this filter field from the name map

backend/internal/entity/setting/methods.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func List(pageInfo model.PageInfo, filters []model.Filter) (entity.ListResponse,
4949
Total: totalRows,
5050
Limit: pageInfo.Limit,
5151
Offset: pageInfo.Offset,
52-
Sort: pageInfo.Sort,
52+
Sort: pageInfo.GetSort(defaultSort),
5353
Filter: filters,
5454
}
5555

backend/internal/entity/stream/methods.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func List(pageInfo model.PageInfo, filters []model.Filter) (entity.ListResponse,
4040
Total: totalRows,
4141
Limit: pageInfo.Limit,
4242
Offset: pageInfo.Offset,
43-
Sort: pageInfo.Sort,
43+
Sort: pageInfo.GetSort(defaultSort),
4444
Filter: filters,
4545
}
4646

0 commit comments

Comments
 (0)