Skip to content

Commit 405f077

Browse files
asgerfmax-schaefer
andauthored
Apply suggestions from code review
Co-authored-by: Max Schaefer <[email protected]>
1 parent b34df9f commit 405f077

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

javascript/ql/src/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataCustomizations.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module ExternalAPIUsedWithUntrustedData {
3434
*
3535
* By default, this includes the objects passed to a `PropertyProjection` or `ExtendCall`.
3636
*
37-
* Such objects tend of have lots of application-defined properties which don't represent
37+
* Such objects tend to have lots of application-defined properties which don't represent
3838
* distinct API usages, so the query will avoid generating API names from them.
3939
*/
4040
abstract class DeepObjectSink extends DataFlow::Node { }
@@ -48,7 +48,7 @@ module ExternalAPIUsedWithUntrustedData {
4848
}
4949

5050
/** Holds if `node` corresponds to a deep object argument. */
51-
private predicate isDeepObjectSink(API::Node node) { node.getARhs() = any(DeepObjectSink deep) }
51+
private predicate isDeepObjectSink(API::Node node) { node.getARhs() instanceof DeepObjectSink }
5252

5353
/**
5454
* A sanitizer for data flowing to an external API.
@@ -136,7 +136,7 @@ module ExternalAPIUsedWithUntrustedData {
136136
}
137137

138138
/**
139-
* Holds `node` may be part of an access path leading to an external API call.
139+
* Holds if `node` may be part of an access path leading to an external API call.
140140
*/
141141
private predicate nodeIsRelevant(API::Node node) {
142142
mayComeFromLibrary(node) and

0 commit comments

Comments
 (0)