C++: Address review.

criemen · criemen · commit b4e45ad6cbe1 · 2020-11-25T16:24:25.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/dataflow/EscapesTree.qll b/cpp/ql/src/semmle/code/cpp/dataflow/EscapesTree.qll
@@ -226,7 +226,8 @@ private predicate addressMayEscapeMutablyAt(Expr e) {
     // If we go through a temporary object step, we can take a reference to a temporary const pointer
     // object, where the pointer doesn't point to a const value
     exists(TemporaryObjectExpr temp, PointerType pt |
-      temp.getConversion() = e and pt = temp.getType().stripTopLevelSpecifiers()
+      temp.getConversion() = e.(ReferenceToExpr) and
+      pt = temp.getType().stripTopLevelSpecifiers()
     |
       not pt.getBaseType().isConst()
     )

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,8 @@ private predicate addressMayEscapeMutablyAt(Expr e) {`
`226`	`226`	`// If we go through a temporary object step, we can take a reference to a temporary const pointer`
`227`	`227`	`// object, where the pointer doesn't point to a const value`
`228`	`228`	`exists(TemporaryObjectExpr temp, PointerType pt \|`
`229`		`- temp.getConversion() = e and pt = temp.getType().stripTopLevelSpecifiers()`
	`229`	`+ temp.getConversion() = e.(ReferenceToExpr) and`
	`230`	`+ pt = temp.getType().stripTopLevelSpecifiers()`
`230`	`231`	`\|`
`231`	`232`	`not pt.getBaseType().isConst()`
`232`	`233`	`)`