Add backend unit tests

Author: jc21

backend/Taskfile.yml

@@ -1,4 +1,4 @@
-version: "2"
+version: "3"
 
 tasks:
     default:

backend/internal/acme/acmesh.go

@@ -136,7 +136,15 @@ func getCommonArgs() []string {
 }
 
 // This is split out into it's own function so it's testable
-func buildCertRequestArgs(domains []string, method, outputFullchainFile, outputKeyFile string, dnsProvider *dnsprovider.Model, ca *certificateauthority.Model, force bool) ([]string, error) {
+func buildCertRequestArgs(
+	domains []string,
+	method,
+	outputFullchainFile,
+	outputKeyFile string,
+	dnsProvider *dnsprovider.Model,
+	ca *certificateauthority.Model,
+	force bool,
+) ([]string, error) {
 	// The argument order matters.
 	// see https://github.com/acmesh-official/acme.sh/wiki/How-to-issue-a-cert#3-multiple-domains-san-mode--hybrid-mode
 	// for multiple domains and note that the method of validation is required just after the ___domain arg, each time.

backend/internal/acme/acmesh_test.go

@@ -193,3 +193,33 @@ func TestBuildCertRequestArgs(t *testing.T) {
 		})
 	}
 }
+
+func TestGetAcmeShFilePath(t *testing.T) {
+	t.Run("basic test", func(t *testing.T) {
+		path, err := getAcmeShFilePath()
+		assert.Equal(t, "/bin/acme.sh", path)
+		assert.Equal(t, nil, err)
+	})
+}
+
+func TestGetCommonEnvVars(t *testing.T) {
+	t.Run("basic test", func(t *testing.T) {
+		expected := []string{
+			"ACMESH_CONFIG_HOME=/data/.acme.sh/config",
+			"ACMESH_HOME=/data/.acme.sh",
+			"CERT_HOME=/data/.acme.sh/certs",
+			"LE_CONFIG_HOME=/data/.acme.sh/config",
+			"LE_WORKING_DIR=/data/.acme.sh",
+		}
+		vals := getCommonEnvVars()
+		assert.Equal(t, expected, vals)
+	})
+}
+
+func TestGetAcmeShVersion(t *testing.T) {
+	t.Run("basic test", func(t *testing.T) {
+		resp := GetAcmeShVersion()
+		assert.Greater(t, len(resp), 1)
+		assert.Equal(t, "v", resp[:1])
+	})
+}

backend/internal/api/context/context_test.go

@@ -0,0 +1,13 @@
+package context
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetString(t *testing.T) {
+	t.Run("basic test", func(t *testing.T) {
+		assert.Equal(t, "context value: Body", BodyCtxKey.String())
+	})
+}

backend/internal/api/filters/helpers.go

@@ -26,7 +26,7 @@ func GetCertificates() func(http.ResponseWriter, *http.Request) {
 			return
 		}
 
-		certificates, err := certificate.List(pageInfo, middleware.GetFiltersFromContext(r), getExpandFromContext(r))
+		certificates, err := certificate.List(pageInfo, middleware.GetFiltersFromContext(r), middleware.GetExpandFromContext(r))
 		if err != nil {
 			h.ResultErrorJSON(w, r, http.StatusBadRequest, err.Error(), nil)
 		} else {
@@ -41,7 +41,7 @@ func GetCertificate() func(http.ResponseWriter, *http.Request) {
 	return func(w http.ResponseWriter, r *http.Request) {
 		if item := getCertificateFromRequest(w, r); item != nil {
 			// nolint: errcheck,gosec
-			item.Expand(getExpandFromContext(r))
+			item.Expand(middleware.GetExpandFromContext(r))
 			h.ResultResponseJSON(w, r, http.StatusOK, item)
 		}
 	}

backend/internal/api/handler/certificates.go

@@ -4,8 +4,6 @@ import (
 	"net/http"
 	"strconv"
 
-	"npm/internal/api/context"
-	"npm/internal/api/middleware"
 	"npm/internal/model"
 
 	"github.com/go-chi/chi/v5"
@@ -15,15 +13,15 @@ import (
 const defaultLimit = 10
 
 func getPageInfoFromRequest(r *http.Request) (model.PageInfo, error) {
-	var pageInfo model.PageInfo
+	pageInfo := model.PageInfo{}
 	var err error
 
 	pageInfo.Offset, pageInfo.Limit, err = getPagination(r)
 	if err != nil {
 		return pageInfo, err
 	}
 
-	pageInfo.Sort = middleware.GetSortFromContext(r)
+	// pageInfo.Sort = middleware.GetSortFromContext(r)
 
 	return pageInfo, nil
 }
@@ -93,12 +91,3 @@ func getPagination(r *http.Request) (int, int, error) {
 
 	return offset, limit, nil
 }
-
-// getExpandFromContext returns the Expansion setting
-func getExpandFromContext(r *http.Request) []string {
-	expand, ok := r.Context().Value(context.ExpansionCtxKey).([]string)
-	if !ok {
-		return nil
-	}
-	return expand
-}