Skip to content

Commit fd27797

Browse files
committed
Complete the removal of Sentry
1 parent aae9579 commit fd27797

File tree

6 files changed

+21
-29
lines changed

6 files changed

+21
-29
lines changed

Jenkinsfile

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -75,22 +75,20 @@ pipeline {
7575
}
7676
stage('Backend') {
7777
steps {
78-
withCredentials([string(credentialsId: 'npm-sentry-dsn', variable: 'SENTRY_DSN')]) {
79-
withCredentials([usernamePassword(credentialsId: 'oss-index-token', passwordVariable: 'NANCY_TOKEN', usernameVariable: 'NANCY_USER')]) {
80-
sh './scripts/ci/test-backend'
81-
}
82-
// Build all the golang binaries
83-
sh './scripts/ci/build-backend'
84-
// Build the docker image used for testing below
85-
sh '''docker build --pull --no-cache \\
86-
-t "${IMAGE}:${BRANCH_LOWER}-ci-${BUILD_NUMBER}" \\
87-
-f docker/Dockerfile \\
88-
--build-arg BUILD_COMMIT="${BUILD_COMMIT}" \\
89-
--build-arg BUILD_DATE="$(date '+%Y-%m-%d %T %Z')" \\
90-
--build-arg BUILD_VERSION="${BUILD_VERSION}" \\
91-
.
92-
'''
78+
withCredentials([usernamePassword(credentialsId: 'oss-index-token', passwordVariable: 'NANCY_TOKEN', usernameVariable: 'NANCY_USER')]) {
79+
sh './scripts/ci/test-backend'
9380
}
81+
// Build all the golang binaries
82+
sh './scripts/ci/build-backend'
83+
// Build the docker image used for testing below
84+
sh '''docker build --pull --no-cache \\
85+
-t "${IMAGE}:${BRANCH_LOWER}-ci-${BUILD_NUMBER}" \\
86+
-f docker/Dockerfile \\
87+
--build-arg BUILD_COMMIT="${BUILD_COMMIT}" \\
88+
--build-arg BUILD_DATE="$(date '+%Y-%m-%d %T %Z')" \\
89+
--build-arg BUILD_VERSION="${BUILD_VERSION}" \\
90+
.
91+
'''
9492
}
9593
post {
9694
success {
@@ -215,12 +213,10 @@ pipeline {
215213
}
216214
}
217215
steps {
218-
withCredentials([string(credentialsId: 'npm-sentry-dsn', variable: 'SENTRY_DSN')]) {
219-
withCredentials([usernamePassword(credentialsId: 'jc21-dockerhub', passwordVariable: 'dpass', usernameVariable: 'duser')]) {
220-
sh 'docker login -u "${duser}" -p "${dpass}"'
221-
sh "./scripts/buildx --push ${buildxPushTags}"
222-
// sh './scripts/buildx -o type=local,dest=docker-build'
223-
}
216+
withCredentials([usernamePassword(credentialsId: 'jc21-dockerhub', passwordVariable: 'dpass', usernameVariable: 'duser')]) {
217+
sh 'docker login -u "${duser}" -p "${dpass}"'
218+
sh "./scripts/buildx --push ${buildxPushTags}"
219+
// sh './scripts/buildx -o type=local,dest=docker-build'
224220
}
225221
}
226222
}

docker/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,12 @@ ARG BUILD_COMMIT
1414
ARG BUILD_VERSION
1515
ARG GOPRIVATE
1616
ARG GOPROXY
17-
ARG SENTRY_DSN
1817

1918
ENV BUILD_COMMIT="${BUILD_COMMIT:-dev}" \
2019
BUILD_VERSION="${BUILD_VERSION:-0.0.0}" \
2120
CGO_ENABLED=0 \
2221
GOPRIVATE="${GOPRIVATE:-}" \
23-
GOPROXY="${GOPROXY:-}" \
24-
SENTRY_DSN="${SENTRY_DSN:-}"
22+
GOPROXY="${GOPROXY:-}"
2523

2624
COPY scripts /scripts
2725
COPY backend /app

scripts/buildx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ docker buildx build \
2424
--build-arg SKIP_TESTS=1 \
2525
--build-arg GOPRIVATE="${GOPRIVATE:-}" \
2626
--build-arg GOPROXY="${GOPROXY:-}" \
27-
--build-arg SENTRY_DSN="${SENTRY_DSN:-}" \
2827
--platform linux/amd64,linux/arm64,linux/arm/7 \
2928
--progress plain \
3029
--pull \

scripts/ci/build-backend

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ build_backend() {
6060
go build \
6161
-tags 'json1' \
6262
-buildvcs=false \
63-
-ldflags "-w -s -X main.commit=${BUILD_COMMIT:-notset} -X main.version=${BUILD_VERSION} -X main.sentryDSN=${SENTRY_DSN:-}" \
63+
-ldflags "-w -s -X main.commit=${BUILD_COMMIT:-notset} -X main.version=${BUILD_VERSION}" \
6464
-o "/app/bin/$FILENAME" \
6565
./cmd/server
6666
}

scripts/ci/test-backend

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ else
5858
-e GOPRIVATE="${GOPRIVATE:-}" \
5959
-e GOPROXY="${GOPROXY:-}" \
6060
-e NOW="$NOW" \
61-
-e SENTRY_DSN="${SENTRY_DSN:-}" \
6261
-e TZ="${TZ:-Australia/Brisbane}" \
6362
-v "$(pwd):/app" \
6463
-w '/app/backend' \

scripts/go-multiarch-wrapper

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ echo -e "${BLUE}❯ ${CYAN}Building binaries for ${YELLOW}${GOARCH} (${TARGETPLA
2626
go build \
2727
-tags 'json1' \
2828
-buildvcs=false \
29-
-ldflags "-w -s -X main.commit=${BUILD_COMMIT:-notset} -X main.version=${BUILD_VERSION} -X main.sentryDSN=${SENTRY_DSN:-}" \
29+
-ldflags "-w -s -X main.commit=${BUILD_COMMIT:-notset} -X main.version=${BUILD_VERSION}" \
3030
-o "${1:-/dist/server}" \
3131
./cmd/server
3232

3333
# ipranges
3434
go build \
3535
-buildvcs=false \
36-
-ldflags "-w -s -X main.commit=${BUILD_COMMIT:-notset} -X main.version=${BUILD_VERSION} -X main.sentryDSN=${SENTRY_DSN:-}" \
36+
-ldflags "-w -s -X main.commit=${BUILD_COMMIT:-notset} -X main.version=${BUILD_VERSION}" \
3737
-o "${2:-/dist/ipranges}" \
3838
./cmd/ipranges
3939

0 commit comments

Comments
 (0)